invidget icon indicating copy to clipboard operation
invidget copied to clipboard

Special characters don't work correctly

Open pedrofracassi opened this issue 5 years ago • 8 comments

After Japanese support was added in #9, I've noticed that the renderer doesn't handle special characters correctly.

Example: https://invidget.switchblade.xyz/discord-developers?language=ja

image

pedrofracassi avatar Aug 21 '20 16:08 pedrofracassi

Discord seems to use Hiragino Sans for japanese. We could try to use that as a fallaback for characters that Whitney doens't support.

pedrofracassi avatar Aug 23 '20 20:08 pedrofracassi

But does it affect all dialects (Hiragana, Katakana and Kanji)? @Flicksie

dsgpaiva avatar Aug 24 '20 11:08 dsgpaiva

Discord seems to use a mix of hiragana and kanji (which should have been displayed in the screenshot above), so I guess it should affect Katakana too.

pedrofracassi avatar Aug 24 '20 11:08 pedrofracassi

Ah, ight. PS: that workaround should also work for server names

dsgpaiva avatar Aug 24 '20 11:08 dsgpaiva

Yeah, I'll probably end up implementing some sort of global font fallback for all the text we render

pedrofracassi avatar Aug 24 '20 12:08 pedrofracassi

in #41 affect this issue.

image in Discord css. it classified by region.

but How about use Noto Sans for these? i know it haven't in Discord Client but I think It covered.

mome0320 avatar Jul 06 '21 02:07 mome0320

Noto Sans doesn't (at least) cover the Korean language, I think. image It could cover other ones, though, but I didn't test it. Most probably we would have to implement Apple SD Gothic Neo, Hiragino Sans, YaHei New and JhengHei.

dsgpaiva avatar Jul 06 '21 08:07 dsgpaiva