tinyglobby icon indicating copy to clipboard operation
tinyglobby copied to clipboard

chore:update engine requirements

Open godky opened this issue 8 months ago • 2 comments

Since this commit uses feature 'AbortController', now our engine requirements should be updated.

godky avatar May 29 '25 09:05 godky

we should probably raise an issue on fdir, since i'm pretty sure they want to remain compatible with node12. i'll merge this if they don't want to keep node12 compatibility

SuperchupuDev avatar May 29 '25 09:05 SuperchupuDev

we should probably raise an issue on fdir, since i'm pretty sure they want to remain compatible with node12. i'll merge this if they don't want to keep node12 compatibility

oh

godky avatar May 29 '25 09:05 godky

I don't think fdir still wants to support a node version from 6 years ago, even node 14 support was debated last year. I think this should be discussed in their open issue about the engines field: https://github.com/thecodrr/fdir/issues/116

Torathion avatar May 29 '25 18:05 Torathion

@godky considering fdir hasn't removed their usage of AbortController and it's been two weeks (with no one reporting any issues) i might merge this. were you affected by fdir breaking node 12 support?

SuperchupuDev avatar Jun 14 '25 11:06 SuperchupuDev

@godky considering fdir hasn't removed their usage of AbortController and it's been two weeks (with no one reporting any issues) i might merge this. were you affected by fdir breaking node 12 support?

@SuperchupuDev Yes, some of our CI environments used node12 and encountered errors, so we upgraded the node version.

godky avatar Jun 16 '25 02:06 godky

fyi i've posted a pinned issue talking about a possible engines update to >=16.0.0 #134

SuperchupuDev avatar Jun 23 '25 13:06 SuperchupuDev

fdir is restoring node 12 support for its next release, as such this won't be needed anymore. thank you for the pr anyways :+1:

SuperchupuDev avatar Jul 08 '25 18:07 SuperchupuDev