sumologic-python-sdk icon indicating copy to clipboard operation
sumologic-python-sdk copied to clipboard

Implement backoff

Open akdor1154 opened this issue 6 years ago • 5 comments

This implements exponential backoff for all Sumologic API calls.

There is also a fix for the endpoint patch that made its way in recently that didn't seem to be tested properly (ping @mccartney), this and a whitespace fix are in separate commits, hope that's OK.

Cheers Jarrad

akdor1154 avatar Jun 18 '19 05:06 akdor1154

This should fix #3 .

akdor1154 avatar Jun 18 '19 05:06 akdor1154

this is a great idea - we have been having rate limiting issues trying to build something on top of this sdk. It would be great to have this fixed inside the python sdk

rickjuryxero avatar Jun 18 '19 23:06 rickjuryxero

Actually request library itself implements exponential backoff we need to pass few parameters to it. Though the solution looks good any specific reason for creating the custom backoff function instead of using builtin solution https://www.peterbe.com/plog/best-practice-with-retries-with-requests

himanshu219 avatar Jun 24 '19 21:06 himanshu219

Oh cool. Happy to go with whatever Sumo team prefer.

akdor1154 avatar Jul 08 '19 00:07 akdor1154

Looking at implementing an API client integration with this library - any prospects for having this bumped/merged soon?

dspruell-s01 avatar Jun 04 '21 01:06 dspruell-s01