Suchitra-Sahoo
Have enabled Light theme option and improved the UI
Related Issue
adding Light theme
Description
Enabled Light and Dark theme and changes in UI like visibility improved.
Type of PR
- [✅ ] Feature enhancement
Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:
-
[ ✅] I have performed a self-review of my code
-
[✅] I have read and followed the Contribution Guidelines.
-
[ ✅] I have tested the changes thoroughly before submitting this pull request.
-
[ ✅] I have provided relevant issue numbers, screenshots, and videos after mak
-
[ ✅] I have commented my code, particularly in hard-to-understand areas.
Keep the text part in home section remain partially transparent only. It doesn't look good in green or white background.
Sorry...I didn't understand about which home text u are talking about And also how should I make the video??? Can u explain in detail once My wtsup mum is 8499980347 Mehrun Shamshi
On Tue, May 21, 2024, 12:54 Suchitra Sahoo @.***> wrote:
Also add a video to demonstrate your changes.
— Reply to this email directly, view it on GitHub https://github.com/Suchitra-Sahoo/AgriLearnNetwork/pull/428#issuecomment-2121934862, or unsubscribe https://github.com/notifications/unsubscribe-auth/A32T5TYYJ3L3PQ33S6CABMLZDLZDZAVCNFSM6AAAAABH76NLX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRRHEZTIOBWGI . You are receiving this because you authored the thread.Message ID: @.***>
"Welcome to AgriLearnNetwork......" Keep its background same as green and white are not looking suitable.
What about light theme than?
Mehrun Shamshi
On Wed, May 22, 2024, 19:54 Suchitra Sahoo @.***> wrote:
"Welcome to AgriLearnNetwork......" Keep its background same as green and white are not looking suitable.
— Reply to this email directly, view it on GitHub https://github.com/Suchitra-Sahoo/AgriLearnNetwork/pull/428#issuecomment-2124935406, or unsubscribe https://github.com/notifications/unsubscribe-auth/A32T5T64QJWPL3KIK3YEE4LZDSTBZAVCNFSM6AAAAABH76NLX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRUHEZTKNBQGY . You are receiving this because you authored the thread.Message ID: @.***>
Attach a video to see how all section are looking in both dark and light mode. I'll suggest you accordingly.
Ok, I will do that.
Mehrun Shamshi
On Wed, May 22, 2024, 20:14 Suchitra Sahoo @.***> wrote:
Attach a video to see how all section are looking in both dark and light mode. I'll suggest you accordingly.
— Reply to this email directly, view it on GitHub https://github.com/Suchitra-Sahoo/AgriLearnNetwork/pull/428#issuecomment-2124984464, or unsubscribe https://github.com/notifications/unsubscribe-auth/A32T5T3NRRVXKYADL6NJDCDZDSVLFAVCNFSM6AAAAABH76NLX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRUHE4DINBWGQ . You are receiving this because you authored the thread.Message ID: @.***>
Mam actually my mail isn't working right and I'm not able to share the video...im sharing the video through my another mail (mail id is : @.***) please check it there...sincere request.
Mehrun Shamshi
On Wed, May 22, 2024, 20:14 MEHRUN SHAMSHI @.***> wrote:
Ok, I will do that.
Mehrun Shamshi
On Wed, May 22, 2024, 20:14 Suchitra Sahoo @.***> wrote:
Attach a video to see how all section are looking in both dark and light mode. I'll suggest you accordingly.
— Reply to this email directly, view it on GitHub https://github.com/Suchitra-Sahoo/AgriLearnNetwork/pull/428#issuecomment-2124984464, or unsubscribe https://github.com/notifications/unsubscribe-auth/A32T5T3NRRVXKYADL6NJDCDZDSVLFAVCNFSM6AAAAABH76NLX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRUHE4DINBWGQ . You are receiving this because you authored the thread.Message ID: @.***>
Mam actually my mail isn't working right and I'm not able to share the video...im sharing the video through my another mail (mail id is : @.***) please check it there...sincere request.
Mehrun Shamshi
On Thu, May 23, 2024, 11:16 MEHRUN SHAMSHI @.***> wrote:
Mam actually my mail isn't working right and I'm not able to share the video...im sharing the video through my another mail (mail id is : @.***) please check it there...sincere request.
Mehrun Shamshi
On Wed, May 22, 2024, 20:14 MEHRUN SHAMSHI @.***> wrote:
Ok, I will do that.
Mehrun Shamshi
On Wed, May 22, 2024, 20:14 Suchitra Sahoo @.***> wrote:
Attach a video to see how all section are looking in both dark and light mode. I'll suggest you accordingly.
— Reply to this email directly, view it on GitHub https://github.com/Suchitra-Sahoo/AgriLearnNetwork/pull/428#issuecomment-2124984464, or unsubscribe https://github.com/notifications/unsubscribe-auth/A32T5T3NRRVXKYADL6NJDCDZDSVLFAVCNFSM6AAAAABH76NLX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRUHE4DINBWGQ . You are receiving this because you authored the thread.Message ID: @.***>
bandicam 2024-05-22 23-13-21-383.mp4 https://drive.google.com/file/d/1s8bdZoLvN8gY5uH6k4Zv6uOBpk82sDBw/view?usp=drive_web
I have also sent the mail to u from my other account also please check mam. Mehrun Shamshi
---------- Forwarded message --------- From: Md Mehboob ali @.> Date: Thu, May 23, 2024, 11:48 Subject: Fwd: To: MEHRUN SHAMSHI @.>
---------- Forwarded message --------- From: Md Mehboob ali @.> Date: Thu, May 23, 2024, 11:39 Subject: To: @.>, < @.>, @.>
bandicam 2024-05-22 23-13-21-383.mp4 https://drive.google.com/file/d/1s8bdZoLvN8gY5uH6k4Zv6uOBpk82sDBw/view?usp=drive_web
Instead of using mail you can directly comment on github. Also i need access of the video. Resolve the conflicts of this branch.
Given the access mam
Mehrun Shamshi
On Thu, May 23, 2024, 12:45 Suchitra Sahoo @.***> wrote:
Instead of using mail you can directly comment on github. Also i need access of the video. Resolve the conflicts of this branch.
— Reply to this email directly, view it on GitHub https://github.com/Suchitra-Sahoo/AgriLearnNetwork/pull/428#issuecomment-2126394721, or unsubscribe https://github.com/notifications/unsubscribe-auth/A32T5T6V63ON7OPBI3URO5TZDWJRPAVCNFSM6AAAAABH76NLX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRWGM4TINZSGE . You are receiving this because you authored the thread.Message ID: @.***>
Which conflicts mam???
Mehrun Shamshi
On Thu, May 23, 2024, 13:22 Suchitra Sahoo @.***> wrote:
Resolve the conflicts too
— Reply to this email directly, view it on GitHub https://github.com/Suchitra-Sahoo/AgriLearnNetwork/pull/428#issuecomment-2126459243, or unsubscribe https://github.com/notifications/unsubscribe-auth/A32T5T6ALTJQOYXP5KKMUKTZDWN3BAVCNFSM6AAAAABH76NLX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRWGQ2TSMRUGM . You are receiving this because you authored the thread.Message ID: @.***>
Open your github accounts and see through the pull request , you will see the conflicts.
Resolved mam
Mehrun Shamshi
On Thu, May 23, 2024, 13:57 Suchitra Sahoo @.***> wrote:
Open you github accounts and see through the pull request , you will see the conflicts.
— Reply to this email directly, view it on GitHub https://github.com/Suchitra-Sahoo/AgriLearnNetwork/pull/428#issuecomment-2126524938, or unsubscribe https://github.com/notifications/unsubscribe-auth/A32T5T4J4FABAJY7SWQFJNDZDWR6NAVCNFSM6AAAAABH76NLX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRWGUZDIOJTHA . You are receiving this because you authored the thread.Message ID: @.***>
Keep this part same in both light and dark mode. The design of the website in dark mode should be same as the current one. In the light mode you can keep your changes. By default the website should be in dark mode and if the user want he can change it to light one.
Yes mam...got ur point...my phone is in repair...so couldn't reply soon to u...vl soon change it and update
Mehrun Shamshi
On Sat, May 25, 2024, 12:55 Suchitra Sahoo @.***> wrote:
Resolve the conflicts
— Reply to this email directly, view it on GitHub https://github.com/Suchitra-Sahoo/AgriLearnNetwork/pull/428#issuecomment-2131039045, or unsubscribe https://github.com/notifications/unsubscribe-auth/A32T5TY433BPCLEHCLDULI3ZEA4FRAVCNFSM6AAAAABH76NLX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZRGAZTSMBUGU . You are receiving this because you authored the thread.Message ID: @.***>
Check these mam...is it ok? Attached pictures of both light and dark mode
Everything is fine. Just don't change colour of this part to dark green or something else.
I didn't change that colour to any new colour...it is kept as it is
Mehrun Shamshi
On Sat, May 25, 2024, 19:32 Suchitra Sahoo @.***> wrote:
Everything is fine. Just don't change colour of this part to dark green or something else. image.png (view on web) https://github.com/Suchitra-Sahoo/AgriLearnNetwork/assets/123376847/259961a0-1197-4378-afa3-f81d3ecdaf5d
— Reply to this email directly, view it on GitHub https://github.com/Suchitra-Sahoo/AgriLearnNetwork/pull/428#issuecomment-2131283706, or unsubscribe https://github.com/notifications/unsubscribe-auth/A32T5T2EB6N5NUBHJMAJTT3ZECKVTAVCNFSM6AAAAABH76NLX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZRGI4DGNZQGY . You are receiving this because you authored the thread.Message ID: @.***>
The background is white in both light and dark theme. You can keep it dark green in dark mode and some light shade in the light mode. Also the headings are not visible properly as colours are too light.
Also the feedback button a little wierd.
Kindly work on these changes.
Also i think you have not pulled changes from origin. Whenever you make a PR do check whether there are any latest changes to pull or not.
Please add level label as it should count towards my GSSoC contribution leaderboard