orchestrator icon indicating copy to clipboard operation
orchestrator copied to clipboard

feat: add profiling steps

Open guilhem-barthes opened this issue 1 year ago • 7 comments

Description

Allow transferring function profiling steps through the orchestrator, allowing the builder to register event without having to have http(s) requests to the backend api server (involving having access to the db to get credentials). This also allows having duration for the function available on every backend.

The drawback of this approach is, how it is relying on the event system already in place, the function profiling are also saved in the DB of the orchestrator.

Fixes FL-1519

Companion PR

  • https://github.com/Substra/substra-backend/pull/886

How has this been tested?

Checklist

  • [ ] changelog was updated with notable changes
  • [ ] documentation was updated

guilhem-barthes avatar Apr 11 '24 08:04 guilhem-barthes

/e2e --tests substra-backend=feat/add-profiling-step-functions

guilhem-barthes avatar Apr 11 '24 08:04 guilhem-barthes

End to end tests: :x: FAILURE

Jobs status:

“You shall not pass!” ― Gandalf, The Lord of the Rings, The Fellowship of the Ring

Owlfred avatar Apr 11 '24 08:04 Owlfred

/e2e --tests substra-backend=feat/add-profiling-step-functions

SdgJlbl avatar Apr 22 '24 08:04 SdgJlbl

End to end tests: :x: FAILURE

Jobs status:

Darn it.

Owlfred avatar Apr 22 '24 08:04 Owlfred

/e2e --tests substra-backend=feat/add-profiling-step-functions

guilhem-barthes avatar May 21 '24 09:05 guilhem-barthes

End to end tests: :x: FAILURE

Jobs status:

“Success is not final; failure is not fatal: It is the courage to continue that counts.” ―- Winston S. Churchill

Owlfred avatar May 21 '24 09:05 Owlfred

/e2e --tests substra-backend=feat/add-profiling-step-functions

guilhem-barthes avatar May 27 '24 13:05 guilhem-barthes

End to end tests: :x: FAILURE

Jobs status:

“Just Keep Swimming!” ― Dory, Finding Nemo

Owlfred avatar May 27 '24 13:05 Owlfred

/e2e --tests substra-backend=feat/add-profiling-step-functions

guilhem-barthes avatar May 27 '24 14:05 guilhem-barthes

End to end tests: :heavy_check_mark: SUCCESS

“Carpe diem. Seize the day, boys.” ― John Keating, Dead Poets Society

Owlfred avatar May 27 '24 14:05 Owlfred

/e2e --tests sdk,substrafl,frontend,documentation,mnist substra-backend=feat/add-profiling-step-functions

guilhem-barthes avatar May 27 '24 15:05 guilhem-barthes

End to end tests: :heavy_check_mark: SUCCESS

You rock!

Owlfred avatar May 27 '24 15:05 Owlfred