AsciiDoc icon indicating copy to clipboard operation
AsciiDoc copied to clipboard

added plugin Paste asciidoc link

Open gAmUssA opened this issue 10 years ago • 5 comments

@FichteFoll please, review

gAmUssA avatar Jan 03 '16 18:01 gAmUssA

You should apply the link replacement to all regions (for sel in self.view.sel():) and not just the first one. That aside, views can actually have "no selections" in which case your code would raise an IndexError.

By the way, you could also implement this as a macro (insert_snippet -> paste), but you're less flexible with specifying the new selections that way.

FichteFoll avatar Jan 04 '16 15:01 FichteFoll

You should also provide the same commands as key bindings for all OSes and not just OSX.

FichteFoll avatar Jan 04 '16 15:01 FichteFoll

@FichteFoll done

gAmUssA avatar Jan 06 '16 03:01 gAmUssA

What about the all selections part?

FichteFoll avatar Jan 07 '16 11:01 FichteFoll

@gAmUssA, can you address these concerns?

You should apply the link replacement to all regions (for sel in self.view.sel():) and not just the first one. That aside, views can actually have "no selections" in which case your code would raise an IndexError.

FichteFoll avatar Jun 08 '18 20:06 FichteFoll