Stypox

Results 524 comments of Stypox

> InfoCache does not need to be reset after applying these changes because it has a lifetime of one session. Is this correct? Yes, and also if it wasn't correct,...

(sorry my mistake, I forgot about #9587)

Ok, I will follow your suggestions. Thank you for the answer! :-D

That's not true, see this screenshot from nightly-26: ![Screenshot_20230111-205745_NewPipe_nightly.png](https://user-images.githubusercontent.com/36421898/211905625-1ac46e11-1c30-4081-ad07-c68a9964c7c1.png)

You have added many unrelated changes (e.g. code style) and have not explained well what you did and how and why you did it. Please remove the unrelated changes and...

(the tests were failing) > /home/runner/work/NewPipe/NewPipe/app/src/main/java/org/schabi/newpipe/player/gesture/BasePlayerGestureListener.kt:40:1: Unexpected indentation (24) (should be 20) (indent) > /home/runner/work/NewPipe/NewPipe/app/src/main/java/org/schabi/newpipe/player/gesture/BasePlayerGestureListener.kt:73:1: Unexpected indentation (24) (should be 20) (indent)

Although this was a really good PR, I'm closing it as the author is not going to contribute to NewPipe anymore. Thanks to everyone involved, we'll try to implement this...

Well, it's a setting that changes how exoplayer seeks, so it's more a tecnichal setting. But yeah, it's arguable whether that setting should be under the exoplayer menu or not.

> Then this PR would raise that requirement to 21, right? Do we want that? If I understand correctly, the purpose of this PR is actually to prevent raising the...

I think it's better if you avoid reflection. We can use our own implementation until the real one becomes available