kolasu icon indicating copy to clipboard operation
kolasu copied to clipboard

Point/Position naming

Open matozoid opened this issue 6 years ago • 1 comments

"Position" sounds like something that is in 1 place. In Kolasu it is more of a range from one point to another.

And of course, Point should be Position as it is in JavaParser :-)

matozoid avatar Jan 09 '20 17:01 matozoid

Another thing to consider, related to this is #27 We should do this refactoring and understand if the name of the source (typically a source file) should go in "Point" -> "Position" or "Position" -> "Range"

ftomassetti avatar Jan 12 '20 11:01 ftomassetti

@mctaverna @alessiostalla @loradd do you have an opinion on the naming of these elements?

ftomassetti avatar Apr 18 '23 07:04 ftomassetti

@ftomassetti I don't really have an opinion, I remember that in GraalVM they have SourceSection.

mctaverna avatar Apr 18 '23 09:04 mctaverna

Monaco/VSCode uses "range" for what we call Position. I wouldn't mind renaming Position to Range (and maybe Point to Position, though that could make migrating a bit confusing)

alessiostalla avatar Apr 18 '23 09:04 alessiostalla

Ok, then I think we converge on renaming Position to Range in Kolasu 1.6. Regarding renaming Point to Position I agree it could make things confusing. Would it make sense to keep Point so that we would have a Range being composed by two Points? This would go in branch 1.6

ftomassetti avatar Apr 18 '23 11:04 ftomassetti

Ok, then I think we converge on renaming Position to Range in Kolasu 1.6. Regarding renaming Point to Position I agree it could make things confusing. Would it make sense to keep Point so that we would have a Range being composed by two Points? This would go in branch 1.6

Yes, I think that renaming Position to Range would be enough not to create too much confusion while achieving our goal.

loradd avatar Apr 18 '23 12:04 loradd

In branch future/16 we completed the renaming

ftomassetti avatar May 03 '23 06:05 ftomassetti