Stranger1992

Results 24 comments of Stranger1992

# QA and Testing ## SMOKE_EMITTER_WHITE (underwater) - OCB 0: Intermittent bubbles emission. Result: Working ✅ - > item.ItemFlags[0]: Result: Working ✅ - > item.ItemFlags[1]: Result: Working ✅ - >...

Further testing: This one is hard to explain but the freeROT is not working with all angles: In editor: ![image](https://github.com/MontyTRC89/TombEngine/assets/84292688/73338c4e-6a15-4038-a416-84ae1a08b7ed) Ingame ![image](https://github.com/MontyTRC89/TombEngine/assets/84292688/60f64331-f2d9-4633-97ac-ad202056d4e4) Project: [SmokeEmitterBug.zip](https://github.com/user-attachments/files/16037355/SmokeEmitterBug.zip) (can use any textures and the...

> Further testing: > > This one is hard to explain but the freeROT is not working with all angles: > > In editor: > > ![image](https://private-user-images.githubusercontent.com/84292688/344330815-73338c4e-6a15-4038-a416-84ae1a08b7ed.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MTQ5OTgsIm5iZiI6MTcxOTYxNDY5OCwicGF0aCI6Ii84NDI5MjY4OC8zNDQzMzA4MTUtNzMzMzhjNGUtNmExNS00MDM4LWE0MTYtODRhZTFhMDhiN2VkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDIyNDQ1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZkNzNiNjQyNDIzY2FiOTdlNWM4MGQ4YTg1ZDA4OTU2MGE5OTU3MjEyNmM3YTI1YTNhNDAxNWNhNDMyZGE0Y2MmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.gJ0wSRlqEFp54Jyjl9d0bQEHLxL4T1HffH5gbC9HN8w) > > Ingame...

@Adngel Hi! Have you got time to look at the above bugs that I encountered so further testing can commence. Thanks in advance.

Retest: * ## FreeROT correctly now working ! ![image](https://github.com/user-attachments/assets/a003f078-7615-42fe-a1b6-7bfd019a9756) ![image](https://github.com/user-attachments/assets/7b918837-a998-40b3-93cc-7de06da3e773) * ## Velocity changes correctly retains angle of emitter ! https://github.com/user-attachments/assets/abc8a26a-09c6-46a9-ab46-5c1eb9528f35 I think this is now good to go. Well...

# Testing Bug: In the below video: I have a node that activates all smoke emitters `OnEnter` . Once I exit they are all disabled `OnLeave` however going back into...

I have tested the above and (aside from the above bug that is unrelated) I think the PR is good to go! All functionality is working as expected. Well done...

@Sezzary may we get your opinion on this?

Tested with older versions: Bug present in 1.7.1 too. Not present in 1.7.0

Hi Illyaine! There has progress at this before. I believe it is coming. I will assign the issue to MontyTRC who handles this.