EasySpin icon indicating copy to clipboard operation
EasySpin copied to clipboard

spidyan/saffron: review

Open spribitzer opened this issue 6 years ago • 2 comments

Before going open source with EasySpin 6.0, the time propagation engine needs to be reviewed and a few things need to be addressed:

  • [ ] Selection of an optimal time step
  • [ ] Related to the time step: dependence of phase on the size step
  • [ ] Issue #147
  • [ ] Issue #155
  • [ ] We should add a figure to the documentation that explains the structure of the output for different types of detection (single point, transient) x (single shot, 1 indirect dimension, n indirect dimensions) x (detection length stays constant between acquisitions, length changes). The documentation should also cover and explain what happens in issue #147 )

spribitzer avatar Oct 23 '19 23:10 spribitzer

there is potential in s_thyme to make code more modular:

  • [ ] propagation step
  • [ ] storing of the detected signal

spribitzer avatar Nov 07 '19 17:11 spribitzer

There is an undocumented feature which allows the user to directly input an IQ (instead of defining pulse parameters). This part of the code needs to be cleaned up and made more modular.

Though it might be useful for some (really advanced) users, it would confuse pulse shaping beginners . If we decide to add this feature to the documentation, we have to be very careful about how and where.

spribitzer avatar Nov 07 '19 19:11 spribitzer