XPath2.Net icon indicating copy to clipboard operation
XPath2.Net copied to clipboard

Check both default namespace and NsXQueryFunc when binding functions

Open binarycow opened this issue 5 years ago • 9 comments

If a document has the default namespace set, FunctionTable.Bind will use that namespace to resolve a function name.

This change will use the default NsXQueryFunc namespace URI if a function does not exist for the user specified namespace URI.

binarycow avatar Sep 16 '20 02:09 binarycow

@binarycow The unit test fail, can you please check?

And also run the https://github.com/StefH/XPath2.Net/tree/master/src/XQTSRun tool to check if the same coverage in % is as before.

StefH avatar Sep 16 '20 08:09 StefH

The unit tests in VS all pass. The XQTSRun tool needs a file? Where do I get that file?

binarycow avatar Sep 16 '20 13:09 binarycow

  1. The unit tests on build server fail.
  2. https://github.com/StefH/XPath2.Net#info has info on how to get the set

StefH avatar Sep 16 '20 13:09 StefH

@binarycow Can you merge latest master from my project into your branch ? I did fix some CI build things.

StefH avatar Jun 21 '21 06:06 StefH

@StefH - rebased

binarycow avatar Jul 04 '21 23:07 binarycow

@binarycow Thanks.

Can you once verify if all tests pass? ""conforms for 12954 from 15133""

StefH avatar Jul 05 '21 14:07 StefH

@binarycow Thanks.

Did you have time to verify if all tests pass? ""conforms for 12954 from 15133""

StefH avatar Jul 12 '21 09:07 StefH

@binarycow I did merge latest master into your branch. And now all the tests from the test suite are also run as a unit test.

And with this change, the test K-SeqExprCast-1422 fails.

Can you investigate ?

StefH avatar Aug 19 '21 20:08 StefH

@binarycow Did you have time to check why test K-SeqExprCast-1422 fails?

StefH avatar Nov 28 '22 19:11 StefH