Steeltoe icon indicating copy to clipboard operation
Steeltoe copied to clipboard

Exposed RelationalDatabaseHealthContributor

Open Levyks opened this issue 5 months ago • 1 comments

Description

Makes Steeltoe.Connectors.RelationalDatabaseHealthContributor public and adds a way to override the Id property and CommandText used to check the DB (default is "SELECT 1;")

The goal of this is to make it easier to implement custom health checks for non-supported databases (like Oracle).

Fixes #1594

EDIT: another benefit is that this would make it possible to add a supported DB to Steeltoe's healthcheck chain without registering it through Steeltoe's connector itself (connectionString managed manually)

Quality checklist

  • [x] Your code complies with our Coding Style.
  • [x] You've updated unit and/or integration tests for your change, where applicable.
  • [ ] You've updated documentation for your change, where applicable. If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • [x] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • [ ] You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

Levyks avatar Sep 13 '25 17:09 Levyks

@dotnet-policy-service agree

Levyks avatar Sep 13 '25 17:09 Levyks

Closing, based on the conversation at #1154. Health contributors are just a small part of the puzzle to make connectors extendable. Please provide the requested input in the linked issue to move this forward.

bart-vmware avatar Dec 15 '25 09:12 bart-vmware