decky-plugin-database icon indicating copy to clipboard operation
decky-plugin-database copied to clipboard

Update TunnelDeck maintainer

Open bkohler616 opened this issue 1 year ago • 4 comments

TunnelDeck

  • Updated to new maintainer
  • Updated decky-frontend-lib to 3.25.0
  • Updated pnpm lock-file to 6.0

This is a fork of the original TunnelDeck, just with the new frontend-lib version. I do not have contact with the developer, and I use this plugin daily.

[If you have not already, please read the review and testing page on the wiki. Remove this line before submitting your plugin.]

Checklist:

Developer Checklist

  • [ ] I am the original author or an authorized maintainer of this plugin. (This is not to the original maintainer's plugin. This is a fork with the updated UI)
  • [X] I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • [X] I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • [ ] I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store. (The original TunnelDeck is technically unique on it's own)

Plugin Backend Checklist

  • No: I am not using a custom backend other than Python.
  • No: I am not using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am not using a custom binary that has all of it's dependencies statically linked.

Testing

  • [X] Tested on SteamOS Preview Update Channel.

bkohler616 avatar May 08 '24 16:05 bkohler616

I realize that this may be a bit unorthodox, and there's sadly not a standard for this instance within the plugins that I'm aware of.

I gave it my best shot though, please let me know.

On Discord, I am .aroe. Feel free to reach out to me if you'd like.

bkohler616 avatar May 08 '24 16:05 bkohler616

While you're changing stuff, it would be easier if you could also switch it to using global DFL (so it doesn't need updates in future).

In rollup.config.js (or .cjs), add decky-frontend-lib to external, and add 'decky-frontend-lib': 'DFL' to output.globals

// truncated, for illustrative purposes
external: [
  'react',
  'react-dom',
+ 'decky-frontend-lib'
],
output: {
  globals: {
    react: 'SP_REACT',
    'react-dom': 'SP_REACTDOM',
+   'decky-frontend-lib': 'DFL'
  }
}

edit: to be clear, I'm happy to approve this once I verify the original dev isn't available anywhere.

PartyWumpus avatar May 08 '24 16:05 PartyWumpus

Hey there! I have applied your recommended changes to the main branch on my repo.

I also adjusted the package.json version number so it should contain a proper new version number. (Did not realize the old guy set the version to 1.0.2 at some point)

And absolutely, I understand.

bkohler616 avatar May 08 '24 16:05 bkohler616

Any updates on the original maintainer? this would help a lot to have this merged in the official branch so the CI/CD can remain in tact and users can just get it through decky like normal :)

ihaddy avatar May 15 '24 17:05 ihaddy

The UI now actually renders, good to send to main store.

PartyWumpus avatar May 26 '24 21:05 PartyWumpus