decky-plugin-database icon indicating copy to clipboard operation
decky-plugin-database copied to clipboard

Update TS3 QuickAccess to v1.1.5

Open ILadis opened this issue 2 years ago • 4 comments

TS3 QuickAccess

This update includes the following changes:

  • Drops tab layout in main view.
  • Adds a settings view which now houses the volume controls.
  • Adds a new section to the settings view to configure a PTT hotkey.
  • Saves/restores PTT hotkey configuration to/from disk (settings file).
  • Updates DFL to latest version (3.25.0)

Checklist:

Developer Checklist

  • [x] I am the original author or an authorized maintainer of this plugin.
  • [x] I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • [x] I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • [x] I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • Yes: I am using a custom backend other than Python.
  • Yes: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • [ ] Tested on SteamOS Preview Update Channel.

ILadis avatar Mar 18 '24 19:03 ILadis

Code looks good for testing!

TrainDoctor avatar Mar 19 '24 01:03 TrainDoctor

@TrainDoctor: I've received some feedback and updated the pull request with some minor changes. I would notify my testers again, once the fixes are pushed to the testing store.

ILadis avatar Mar 24 '24 09:03 ILadis

Thanks @RodoMa92 for approving my changes.

For some reason the plugin failed to build. Skimming over the build output I can see, that an old commit was used. I updated my pull request to point to the latest commit (I haven't made any changes to the source since my last comment).

The actual error that caused the build to fail was apparently something different though:

rm: cannot remove 'out/': Device or resource busy
make: *** [Makefile:44: clean] Error 1

Maybe retrying the build could fix this?

ILadis avatar Apr 19 '24 22:04 ILadis

Thanks @RodoMa92 for approving my changes.

For some reason the plugin failed to build. Skimming over the build output I can see, that an old commit was used. I updated my pull request to point to the latest commit (I haven't made any changes to the source since my last comment).

The actual error that caused the build to fail was apparently something different though:

rm: cannot remove 'out/': Device or resource busy
make: *** [Makefile:44: clean] Error 1

Maybe retrying the build could fix this?

Let's test this. Reran now.

EDIT: Yep, it's in. Github weirdness, I guess.

RodoMa92 avatar Apr 22 '24 09:04 RodoMa92

Tested it yesterday, here's my report:

Decky v2.12.0, SteamOS 3.5.19

A) ~~PTT settings are either not working for me or I'm just dumb :) "PTT not available. Additional setup is required" Already tried activating PTT in TS3 first, but can't get past that message. If it's indeed working, there should be some sort of "setup steps" in order to get it running.~~ Works as intended after running the flatpak override command, see answer from @ILadis below

B) see above, if it's a setup issue Edit: Implementing a button "Enable PTT" is a great idea to handle the setup for the user

C)

  • CSS Loader 2.2.1-a6b5353
  • Decky Terminal 0.4.1-53a5f66
  • HLTB for Deck 1.4.1-c1cd103
  • NonSteamLaunchers 1.0.0-91b52e1
  • SteamGridDB 1.4.0-030f9a1
  • Storage Cleaner 1.3.1-7c3bcb0
  • TabMaster 2.5.4-7b9474b
  • TS3 QuickAccess 1.1.5-3143b8b
  • Wine Cellar 0.1.5-c1e664b
  • MagicBlack 1.0.1-044f6d3

D) ~~Probably yes, but only if the PTT "issue" originates from a missing setup. Other features like the volume bar settings are working fine.~~ Yes

lutzgooren avatar May 19 '24 06:05 lutzgooren

Thanks for testing the plugin!

There are indeed some additional setup steps required in order to make PTT work. This is currently only mentioned in the README:

If you want to use Push-to-Talk allow TeamSpeak to access your Steam Deck inputs: flatpak override --user com.teamspeak.TeamSpeak3 --device=all

I'd consider adding an "Enable PTT" button in the next version of the plugin which executes this command for the user.

ILadis avatar May 19 '24 07:05 ILadis

Tested today

Decky v2.12.0, SteamOS 3.5.19

A) nope B) nope C) CSS Loader 2.2.1-a6b5353 TS3 QuickAccess 1.1.5-3143b8b D) yes

thank you for this great plugin. it's just awesome

SaulGoodman1337 avatar May 22 '24 21:05 SaulGoodman1337