decky-plugin-database icon indicating copy to clipboard operation
decky-plugin-database copied to clipboard

add NonSteamLaunchers as a Decky Plugin

Open moraroy opened this issue 2 years ago • 55 comments

NonSteamLaunchers

Installs the latest GE-Proton and Installs Non Steam Launchers under 1 Proton prefix folder or separately and adds them to your steam library. Installs... Battle.net, Epic Games, Ubisoft, GOG, Origin, The EA App, Amazon Games, itch.io , Legacy Games, The Humble Games Collection, IndieGala, Rockstar Games Launcher, Glyph and Minecraft. Now with SD Card Support. Now includes automatic game scanning for the the launchers.

Checklist:

Developer Checklist

  • [x] I am the original author or an authorized maintainer of this plugin.
  • [x] I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • [x] I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • [x] I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • [ ] Tested on SteamOS Stable/Beta Update Channel.

moraroy avatar Jan 24 '24 06:01 moraroy

@Tormak9970 @TrainDoctor i think im ready now, sorry for all the mistakes before. this one is ready, just tested on stable and is working.

moraroy avatar Jan 24 '24 06:01 moraroy

@SteamDeckHomebrew/decky-testers looking for users to evaluate this plugin. Thanks.

TrainDoctor avatar Feb 15 '24 04:02 TrainDoctor

@TrainDoctor hey train I have some big changes coming for this plugin in the next week or so, currently working on it as we speak. Just wanted to share.

moraroy avatar Feb 15 '24 04:02 moraroy

@TrainDoctor hey train I have some big changes coming for this plugin in the next week or so, currently working on it as we speak. Just wanted to share.

Do you think it's better to get those changes evaluated as a part of this PR or to get a known working version tested and out to users?

TrainDoctor avatar Feb 15 '24 04:02 TrainDoctor

@TrainDoctor have no idea. Currently this pr works though! Didn't know what you meant by telling other users to test. I thought maybe you were going to delete the pr lol my bad brother

moraroy avatar Feb 15 '24 04:02 moraroy

@TrainDoctor have no idea. Currently this pr works though! Didn't know what you meant by telling other users to test. I thought maybe you were going to delete the pr lol my bad brother

PRs never get deleted just closed, but understandable. Not to worry for you.

TrainDoctor avatar Feb 15 '24 05:02 TrainDoctor

@TrainDoctor hey train i had some weird conflicts but i believe i have fixed them... i was attempting to also update my pull request to the latest version with all the new changes but im not sure if my changes reflected that? if so i believe it is ready to go to testing!

moraroy avatar Mar 20 '24 15:03 moraroy

@TrainDoctor hey train i had some weird conflicts but i believe i have fixed them... i was attempting to also update my pull request to the latest version with all the new changes but im not sure if my changes reflected that? if so i believe it is ready to go to testing!

You were close but I pushed an update that should sort it now.

TrainDoctor avatar Mar 20 '24 19:03 TrainDoctor

@TrainDoctor 😓 the push to update the submodule didn't go through I guess, it's showing the same version. Now that you fixed it though, I'll do another submodule plugin update.

moraroy avatar Mar 20 '24 20:03 moraroy

@TrainDoctor 😓 the push to update the submodule didn't go through I guess, it's showing the same version. Now that you fixed it though, I'll do another submodule plugin update.

Yeah so all you should need to do is update your main branch and the PR should pull that in automatically. I would recommend making a branch that's dedicated for updates to the Decky Store and pin your submodule to that so you can update your main branch independently and then merge changes into the store/store-submission branch (etc) whenever you make PRs like this. I don't know if this would be directly helpful to your situation though.

TrainDoctor avatar Mar 20 '24 20:03 TrainDoctor

@TrainDoctor gotcha ok yeah i didnt even know i could do that, so everytime i push updates my plugin, the Pull Request will automatically grab that!? thats really cool, currently though, im not sure if its getting my most recent branch i guess? the one in the testing store now isnt the right one, i checked my package.json and they are all bumped to 1.0 in my plugin repo. so i think im missing something here haha

moraroy avatar Mar 20 '24 20:03 moraroy

@TrainDoctor gotcha ok yeah i didnt even know i could do that, so everytime i push updates my plugin, the Pull Request will automatically grab that!? thats really cool, currently though, im not sure if its getting my most recent branch i guess? the one in the testing store now isnt the right one, i checked my package.json and they are all bumped to 1.0 in my plugin repo. so i think im missing something here haha

It looks like you need to update the submodule within your fork of the plugin database from a quick glance. If you keep the submodule up to date in your plugin database fork then I'm guessing the plugin will showing the updated files you're expecting.

TrainDoctor avatar Mar 20 '24 20:03 TrainDoctor

@TrainDoctor gotcha bro, ok, i believe i updated that correctly now....haha thanks for being patient with me brother. i hope it builds!

moraroy avatar Mar 20 '24 21:03 moraroy

@TrainDoctor hey train could you approve this build to the testing store, if it it doesn't bump the build number, i may need some help to see whats going on, i believe the sub-module was updated on this hash "a479145"

moraroy avatar Mar 24 '24 16:03 moraroy

Just in case you haven't, could you join on our discord to test other devs that are also waiting for testing their plugins in order to see if you can help each other out? We are quite in the need for testers rn. Thanks in any case!

RodoMa92 avatar Apr 23 '24 08:04 RodoMa92

@RodoMa92 I am in the discord!

moraroy avatar Apr 23 '24 08:04 moraroy

@RodoMa92 could you approve the latest? we believe the plugin itself would be ready for main.

moraroy avatar May 03 '24 00:05 moraroy

@TrainDoctor @RodoMa92 ready to merge to main with the latest build if possible

moraroy avatar May 06 '24 14:05 moraroy

Works great, look forward to the normies getting a hand on this

livejamie avatar May 16 '24 06:05 livejamie

@TrainDoctor @RodoMa92 @Tormak9970 @PartyWumpus I don't know who's part of the core team so I don't know who else to tag @AAGaming00 I'm sorry for arguing with you guys in their but it's been a long wait. https://youtu.be/Qb4A9Wkd200?si=7ZRCwmj-kHHMoF4P

moraroy avatar May 21 '24 01:05 moraroy

Works great, look forward to the normies getting a hand on this

Same. This is brilliant and so easy to install now with decky.

It's a must have for sure!

githubUser01946 avatar Jun 04 '24 11:06 githubUser01946

Noticed there is a decky version of this software and tried it instantly and it looks beautiful! I had to change my decky store to the preview test branch thing though, even though it seems to be working just fine! Am I missing something?:o

BakaKuma-uwu avatar Jun 11 '24 21:06 BakaKuma-uwu

Noticed there is a decky version of this software and tried it instantly and it looks beautiful! I had to change my decky store to the preview test branch thing though, even though it seems to be working just fine! Am I missing something?:o

I think we are all waiting for all of the Decky team to allow it or something for it to exit beta.

githubUser01946 avatar Jun 11 '24 21:06 githubUser01946

@AAGaming00 ok but why is everyone messaging me about this? I'm confused why decky is allowed to do it but I can't?

"Open the Return to Gaming Mode shortcut on your desktop.

There is also a fast install for those who can use Konsole. Run curl -L https://github.com/SteamDeckHomebrew/decky-installer/releases/latest/download/install_release.sh | sh and type your password when prompted." This on the github.... and I've used a .desktop file for NonSteamLaunchers since the beginning... I get it, but I'm just confused

moraroy avatar Jun 12 '24 12:06 moraroy

Decky has to obviously download itself to install, how else could it work?

Plugins are required to go through our review and downloading code bypasses said review. If you need external files, vendor them or use the remote_download feature

AAGaming00 avatar Jun 12 '24 12:06 AAGaming00

To be clear, the issue isn't that you're specifically using curl | bash, it's that you're downloading and executing code we can't audit

AAGaming00 avatar Jun 12 '24 12:06 AAGaming00

@AAGaming00 even if the code itself is public? And on a github? Used by thousands of people? I mean isn't it kind of obvious that there is nothing wrong with the code it's downloading? Again, don't get me wrong, I'm open to changing things I'm just trying to wrap my head around everything.

moraroy avatar Jun 12 '24 12:06 moraroy

Yes, because you could change that code remotely at any time and we wouldn't be able to stop it from executing on users' consoles.

AAGaming00 avatar Jun 12 '24 12:06 AAGaming00

If you need to download external code, use the remote_download (remote_binary? I forget the name.) feature, it checks that the downloaded code matches a static hash before allowing the plugin installation to continue.

AAGaming00 avatar Jun 12 '24 12:06 AAGaming00

@AAGaming00 you're going to have to teach me how I go about doing that then, I've never heard of that before

moraroy avatar Jun 12 '24 13:06 moraroy