aaw icon indicating copy to clipboard operation
aaw copied to clipboard

Add VS code to sas image on AAW

Open melissavanbussel opened this issue 3 years ago • 1 comments

Is your feature request related to a problem? Please link issue ticket

Visual Studio Code is currently available on the jupyterlab image but not on the sas image, on AAW.

Describe the solution you'd like

  • Please add VS code to the sas image on AAW, similarly to how it's available on the jupyterlab image
  • For Protected B notebooks, is it possible to have common VS code extensions that might be needed, added? (Specifically, the R extension, the Python extension, and the Quarto extension)

melissavanbussel avatar Oct 19 '22 17:10 melissavanbussel

This would also be a priority for me!

Eric-Fecteau-Statcan avatar Oct 20 '22 18:10 Eric-Fecteau-Statcan

@melissavanbussel @Eric-Fecteau-Statcan Extensions have been added to VS code. Unfortunately, I wasn't able to get the VSCode icon to show up on the jupyterlab home screen but instead you can run `code-server --link' in terminal and run the URL to launch an instance of VSCode. Please verify this

rohank07 avatar Oct 26 '22 15:10 rohank07

Hello @rohank07, I have tested and it does not work on a Protected B image (see error below) and requires a Github login on non-Protected B. This is not how the VSCode works on the jupyterlab-cpu:v1 image. It works on the Protected B image and it does not require Github on the non-protected. We would need the same solution on the SAS image as exists on the jupyterlab image!

[2022-10-26T15:20:56.067Z] info  Wrote default config file to ~/.config/code-server/config.yaml
[2022-10-26T15:20:56.421Z] info  code-server 4.5.1 97d170331b51ee75c8e4bbdab23c755e3eeaaa8c
[2022-10-26T15:20:56.422Z] info  Using user-data-dir /etc/share/code-server
[2022-10-26T15:20:56.434Z] info  Using config file ~/.config/code-server/config.yaml
[2022-10-26T15:20:56.434Z] info  HTTP server listening on http://127.0.0.1:44879/ (randomized by --link)
[2022-10-26T15:20:56.434Z] info    - Authentication is disabled (disabled by --link)
[2022-10-26T15:20:56.434Z] info    - Not serving HTTPS (disabled by --link)
[2022-10-26T15:21:06.641Z] info  ping server: dial server: failed to WebSocket dial: failed to send handshake request: Get "https://cloud.coder.com/latency": read tcp 10.133.128.16:44396->104.18.5.89:443: read: connection reset by peer

On the jupyterlab, VSCode is intalled here (see end of path): https://kubeflow.aaw.cloud.statcan.ca/notebook/project/server/vscode

Eric-Fecteau-Statcan avatar Oct 26 '22 15:10 Eric-Fecteau-Statcan

@Eric-Fecteau-Statcan It should be functional now

rohank07 avatar Oct 27 '22 00:10 rohank07

Hello @rohank07, it is functional! Thank you. The Quarto VSCode extention (available on the Protected B jupyterlab-cpu:v1) is not available on the sas:final VSCode while Protected B. Could this be added?

Also, how do I request an update to all the VSCode extentions (for the SAS image and for the jypyterlab image) for Protected B. They get automatically updated on the non-protected B version, but any time we run a protected B notebook, we have to use seriously outdated versions (e.g. the R language support is version v1.6.6, but the current version is 2.4.0).

Eric-Fecteau-Statcan avatar Oct 27 '22 11:10 Eric-Fecteau-Statcan

To see the Quarto extension you would have to spin up a new non-prob jupyterlab-cpu:v1 notebook. We would not be able to add it to sas:final. I will update the VSCode extensions to latest version this morning.

rohank07 avatar Oct 27 '22 12:10 rohank07

Thank you so much for updating the VSCode extentions! It is extremely appreciated!

And I understand for Quarto. I see the Quarto VSCode extension on protected B jupyterlab, but Quarto itself is not installed. How would we go about installing Quarto (another Gitlab issue)? Do we simply have to wait until RStudio is installed on the SAS image to have access to Quarto?

Eric-Fecteau-Statcan avatar Oct 27 '22 12:10 Eric-Fecteau-Statcan

Yeah, that would require a seperate issue. Does Quarto need RStudio installation or can it be installed independently?

rohank07 avatar Oct 27 '22 13:10 rohank07

It can be installed independently of RStudio! We will definitely create another issue for this!

Eric-Fecteau-Statcan avatar Oct 27 '22 14:10 Eric-Fecteau-Statcan

@Eric-Fecteau-Statcan The extensions have been updated

rohank07 avatar Oct 28 '22 12:10 rohank07

Thank you so much!

Eric-Fecteau-Statcan avatar Oct 28 '22 12:10 Eric-Fecteau-Statcan

Thank you so much for your help, @rohank07! I created a new issue for Quarto: https://github.com/StatCan/daaas/issues/1408

melissavanbussel avatar Oct 28 '22 19:10 melissavanbussel