aaw icon indicating copy to clipboard operation
aaw copied to clipboard

Upgrade 1.4: Inquire about how to rebase JWA

Open wg102 opened this issue 3 years ago • 3 comments

Sub item of epic: https://github.com/StatCan/daaas/issues/1242 Ask the people who did the rebase previously. The issue is that it comes from a different repository.

Front end and backend.

wg102 avatar Aug 24 '22 13:08 wg102

Backend

After a quick chat with Will, it seems the way they have done the update previously is to launch the upstream jupyter-api, then open devtools and take a look at any of the requests that the webapp is making to the backend, along with their payloads and then update the golang schema for any corrections.

Frontend

What to do with the front end?... The big changes are: Migrate to Angular 12 from 8: Merging our i18n Refactor i18n to use angular's default

Option 1: Create a new master branch, copy the file directories Redo all our work on top of it

Option 2: Manually do the upgrade to angular 12 Manually do any additional changes from their side.

wg102 avatar Aug 25 '22 15:08 wg102

I will be going with option 1. Between the big changes they did it should be fast enough to do our own modifications on top. I will make the list and execute it.

wg102 avatar Aug 25 '22 18:08 wg102

This is the physical differences, there are also a lot of validation image The volume table The price table

wg102 avatar Sep 01 '22 13:09 wg102

The investigation is done. There is a ticket on how to deploy angular

wg102 avatar Sep 06 '22 18:09 wg102

See https://github.com/StatCan/jupyter-apis/issues/126

wg102 avatar Sep 06 '22 18:09 wg102