aaw
aaw copied to clipboard
StatCan
Upgrade 1.4: JWA
This issue is a child of https://github.com/StatCan/daaas/issues/1203
And Will be done in parallel with the Kubeflow-centraldashboard upgrade.
Steps
- Figure how to do the rebasing
- Investigate the difficulty of the tasks, both for frontend and backend + create tickets
- Fix backend https://github.com/StatCan/jupyter-apis/issues/125
- Fix frontend
We need to consider merging our front end with the kubeflow repo, to get all the changes in one go. It will be harder to do, but once done, should be easy enough to maintain. This would allow us to have a more structured approach in future upgrades.
| Original Title | Date | Description | Pull request # | Note | Issue TODO |
|---|---|---|---|---|---|
| feat(initial): Initial commit | 20/08/10 | 641a4d6 | NA | Directly on main | NA |
| feat(initial): Initial commit | 20/08/10 | 7f366f8 | NA | Directly on main | X |
| feat(notebooks): Add initial support for creating and delete notebooks | 20/08/10 | d36aff0 | NA | Directly on main | X |
| chore(notebooks): Code linting | 20/08/10 | 4baa196 | NA | Directly on main | X |
| fix(http): Set Content-Type on response | 20/08/11 | d72939d | NA | Directly on main | X |
| feat(notebooks): Add volume and GPU support on Notebook creation | 20/08/11 | 0f3a9ba | NA | Directly on main | X |
| feat(listers): Switch to informers + listers to reduce the number of calls … | 20/08/11 | a8363a5 | NA | Directly on main | X |
| feat(config): Add config | 20/08/11 | e3bcdf7 | NA | Directly on main | X |
| feat(frontend): Add jupyter frontend | 20/08/11 | 16bd974 | NA | Directly on main | X |
| chore(license): Add frontend license | 20/08/11 | f09fe91 | NA | Directly on main | X |
| feat(notebooks): Display CPU limits as a decimal | 20/08/12 | 2f4546a | NA | Directly on main | X |
| feat(configurations): Add configurations to the notebooks | 20/08/12 | 42c7019 | NA | Directly on main | X |
| feat(namespaces): Add namespaces response | 20/08/13 | 4370e46 | NA | Directly on main | X |
| feat(response): Update error responses to HTTP 200 because the web in… | 20/08/13 | 73fafd8 | NA | Directly on main | X |
| fix(notebooks): Return index.html when the new page is requested | 20/08/14 | c6280e4 | NA | Directly on main | X |
| feat(ci): Automate build and publish | 20/08/16 | 22f2749 | NA | Directly on main | not sure, relates to Github ci |
| feat(ci): Temporarily set back container | 20/08/16 | 2c07e8d | NA | Directly on main | not sure, relates to Github ci |
| feat(ci): Automate build and publish | 20/08/16 | 3c844b4 | NA | Directly on main | not sure, relates to Github ci |
| fix(npm): fix vulnerabilities (squashed commit) | 20/08/19 | d32875d | +5 | ||
| Merge pull request #5 from StatCan/try-npm-fix | 20/08/19 | c4e6fa7 | 5 | X | |
| fix: Update from deprecated font-awesome usage | 20/08/19 | b7ee560 | +6 | ||
| feat: Improve local dev setup | 20/08/19 | f3eb3cd | +6 | ||
| refactor: Remove unneeded statements, unreachable code | 20/08/19 | 7d98d21 | +6 | ||
| Merge pull request #6 from StatCan/2-facilitate-local-development | 20/08/20 | 7ad65c2 | 6 | X | |
| chore: Unset executable flag on front-end files | 20/08/21 | 3bdcc83 | +13 | ||
| fix: angular mat-form-fiel error | 20/08/21 | 20ff2f9 | +9 | ||
| Merge pull request #9 from StatCan/fix-angular-component | 20/08/21 | f0b855d | 9 | X | |
| fix: kubeflow collision | 20/08/21 | f068e8d | +12 | ||
| Merge pull request #12 from StatCan/fix-kubeflow-collision-information | 20/08/21 | 5caa0a4 | 12 | X | |
| Merge pull request #13 from StatCan/3-fix-front-end-file-permissions | 20/08/21 | 978c814 | 13 | merging the flag changes | |
| docs: Update README for local development | 20/08/25 | 90a1e14 | + 14 | ||
| docs: Update README | 20/08/25 | 223b9ec | + 14 | ||
| Merge pull request #14 from StatCan/update-read-me | 20/08/25 | 831d42c | 14 | X | |
| fix: limit local dev deployment | 20/08/26 | 47455b0 | + 15 | ||
| Merge pull request #15 from StatCan/11-limit-local-dev-deployment | 20/08/26 | 692c8f4 | 15 | X | |
| chore(fonts): add fonts as assets | 20/08/26 | 2a1317b | + 17 | ||
| chore(fonts): add fonts to service | 20/09/01 | e9c0fdb | + 17 | ||
| Merge pull request #17 from StatCan/fonts-as-assets | 20/09/01 | 76dcb7b | 17 | X | |
| fix(Dockerfile): add env variable | 20/09/14 | 282b887 | + 21 | ||
| Merge pull request #21 from StatCan/add-env-variable | 20/09/14 | 0d174a0 | 21 | X | |
| fix: notebook server validation | 20/09/15 | 1e66633 | + 19 | ||
| fix: Fix cross-validation issues, error messages | 20/09/05 | 32eb310 | + 19? | ||
| fix: Gi for RAM not optional | 20/09/16 | 9cbb66c | + 19 | ||
| Merge pull request #19 from StatCan/notebook-server-validation | 20/09/16 | 22bdc13 | 19 | X | |
| fix: delete old notebooks (pvc) | 20/09/17 | 2095188 | + 20 | ||
| fix: resolve dependabot alerts | 20/09/23 | faf5415 | +23 | ||
| feat: Add icons to main tables + refactor | 20/09/23 | fdb507f | +20 | ||
| fix: browser console ExpressionChanged error | 20/09/24 | d2a9537 | +23 | ||
| Merge pull request #23 from StatCan/fix-dependabot-alerts | 20/09/24 | 1a50add | 23 | X | |
| fix: Add status to pvc table + refactor | 20/10/02 | 49fc2b3 | + 20? | ||
| feat: Convey more info via volume status column | 20/10/06 | 4fabd14 | +20 | ||
| Merge pull request #20 from StatCan/18-destroy-old-notebooks | 20/10/06 | 2e9daf6 | 20 | X | |
| feat: add cost estimate table | 20/10/06 | b08cb88 | + 27 | ||
| fix: Improve spacing for new data volume config | 20/10/07 | 8df1dc8 | + 29 | ||
| Merge pull request #29 from StatCan/28-data-volume-ui-is-squashed | 20/10/07 | 738e6fd | 29 | X | |
| Add message when shoose image | 20/10/13 | a9e122a | + 30 | ||
| use Prettier | 20/10/13 | 52cc62b | + 30 | ||
| Merge pull request #30 from StatCan/Change-the-hint-image-message | 20/10/14 | 9d02488 | 30 | X | |
| fix: connect to Kubecost API + cleanup and refactor components | 20/10/21 | 2284c4d | + 27 | ||
| Merge pull request #27 from StatCan/kubecost-estimates | 20/10/21 | 49dea69 | 27 | X | |
| fix: update ram limits | 20/11/03 | f8c29ee | +38 | ||
| Merge pull request #38 from StatCan/fix-max-limits | 20/11/03 | 344d4fc | 38 | X | |
| feat: Add Official Languages with ngx-translate | 20/11/04 | 2e213ec | + 35 | ||
| Merge pull request #35 from StatCan/32-angular-ngx-translate | 20/11/04 | f938db9 | 35 | X | |
| fix: add check for kubecost error response + translation | 20/11/06 | 460f113 | + 34 | ||
| Merge pull request #34 from StatCan/fix-kubecost-error | 20/11/06 | d412a39 | 34 | X | |
| fix: kubecost table message | 20/11/10 | aeddf81 | + 40 | ||
| Merge pull request #40 from StatCan/fix-kubecost-message | 20/11/10 | 0fba437 | 40 | X | |
| fix: set max cpu/ram values for 1 gpu + translation | 20/12/16 | 6c5fa37 | + 45 | ||
| Merge pull request #45 from StatCan/fix-gpu-specs | 20/12/16 | 0e116fd | 45 | X | |
| feat: Add validation for mounted pvc | 21/01/04 | f2614b6 | +51 | ||
| fix: show error when element is untouched | 21/01/04 | 22805a3 | + 51 | ||
| Merge pull request #51 from StatCan/50-add-validation-mounted-pvc | 21/01/07 | 8641aab | 51 | X | |
| fix: add check for runnning notebook server | 21/01/07 | b8a3683 | +53 | ||
| Merge pull request #53 from StatCan/fix-upstream-error | 21/01/13 | 424b2f9 | 53 | X | |
| feat: Add env variable to set language of the notebook server | 21/01/21 | 83af673 | +48 | ||
| Merge pull request #48 from StatCan/feat-env-var | 21/01/21 | 2c1532b | 48 | X | |
| fix npm vulnerabilities | 21/01/25 | 197905b | +54 | ||
| Merge pull request #54 from StatCan/52-fix-npm-vulnerabilities | 21/01/26 | d0b5f20 | 54 | X | |
| fix: lower gpu node cpu-request to allow scheduling | 21/02/12 | 33372de | +57 | ||
| Merge pull request #57 from StatCan/lower-gpu-cpu-request | 21/02/16 | 0b55d4d | 57 | X | |
| feat: url link to image info page | 21/04/20 | 68c6546 | + 60 | ||
| Merge pull request #60 from StatCan/image-selection-hint | 21/04/20 | 5daefc3 | 60 | X | |
| Update README.md | 21/05/12 | 32a6c91 | NA | Directly on main | |
| docs: additional info for miniKF | 21/05/19 | 37c5e7c | NA | Directly on main | |
| fix: added custom image url validation | 21/05/20 | 4e2554f | + 61 | ||
| Merge pull request #61 from StatCan/59-add-custom-image-url-validation | 21/05/21 | 416bcb1 | 61 | X | |
| fix(prob volumes) | 21/09/22 | da808ea | 63 | X | |
| fix(use the better label) | 21/09/22 | e0a6302 | 64 | X | |
| add prob volume label | 21/09/29 | 24e2ce1 | 66 | X | |
| feat(initial): Initial baseline | 22/02/15 | cd1e003 | N/A | Directly on main | |
| feat(frontend): Switch to upstream frontend v1.3.0 | 22/02/15 | dfa205f | N/A | Directly on main | |
| feat(endpoint): Add update notebook start / stop endpoint | 22/02/16 | dcfba4c | N/A | Directly on main | |
| feat: Update for Kubeflow v1.3.0 | 22/02/17 | 863a996 | 67 | X | |
| feat(ci): Fix for node-gyp on npm ci | 22/02/17 | cdedc61 | N/A | Directly on main | |
| feat(ci): Fix pathprefix for static | 22/02/17 | e8a39d8 | N/A | Directly on main | |
| fix: Return index.html page at the root | 22/02/17 | 6bed652 | N/A | Directly on main | |
| fix: Strip /static prefix from static resources when sent to the filesystem | 22/02/17 | acd0d75 | N/A | Directly on main | |
| feat(doc): Update README.md and SpawnerConfig | 22/03/06 | 0d3f2bc | N/A | Directly on main | |
| feat(i18n): Add i18n functionality on top of KF 1.3 | 22/03/07 | 813f13a | N/A | Directly on main | |
| feat(ux): Add custom UX improvements + fix():remove kubecost table | 22/03/11 | 3f6d99b | 115 | X | |
| update spawner_ui_config | 22/03/11 | 866a7c8 | 116 | X | |
| feat: change cpu limit | 22/04/11 | bdf857c | 119 | X | |
| Update Readme | 22/04/11 | b837df3 | 118 | X | |
| feat(imagePullPolicy): Change to Always | 22/05/04 | 2113334 | 120 | X | |
| feat(imagePullPolicy): Add and set it | 22/06/06 | d105c5a | 121 | X |
TODO LIST:
- [ ] Figure how to deploy the code into dev correctly https://github.com/StatCan/jupyter-apis/issues/126
- [ ] The kubecost table
- [ ] The Volume table
We might want to pay a closer attention to this commit: https://github.com/StatCan/jupyter-apis/commit/863a996748b37e94aae013ea9de3d640af530423 It's the upgrade for 1.3.
We will also need to figure out what to do with the Golang Backend, and update the Build scripts accordingly
Need to decide if we merge it back into the kubeflow repo, or not. And write down the reason for/against. And the final decision. This will have a big impact. This decision will be tracked in the following ticket: https://github.com/StatCan/daaas/issues/1302
Halfway done grouping the PRs together, will finish on Monday, and finish the table up to date (there was kubecost back too)
A new epic was created to handle those commits to redeploy. See https://github.com/StatCan/jupyter-apis/issues/131