aaw icon indicating copy to clipboard operation
aaw copied to clipboard

Identify and enable Seldon network access in all AAW namespaces.

Open chritter opened this issue 3 years ago • 6 comments

Currently, Seldon deployments are not accessible due to network restrictions and require a special network setup, as identified and used in #798. The network settings need to be adapted for all namespaces.

Example use case to test: https://gitlab.com/dsd4/seldon_api_deploy/argo_seldon_deployments/-/tree/master/01_getting-started.

Specific goals:

  • Enable and refine setup for iris deployment example so that it works across all namespaces
  • Enable access via Seldon Python SDK as shown here. This requires configuring the python client appropriately.

chritter avatar Apr 19 '22 13:04 chritter

Network policy label selector?

labels:
      notebook-name: seldondeployment

chritter avatar May 12 '22 20:05 chritter

Preventing istio injection to allow init container with model to start:

  annotations:
    sidecar.istio.io/inject: "false"

chritter avatar May 12 '22 20:05 chritter

-name: seldondeployment

Is not needed anymore according to Blair.

chritter avatar May 12 '22 20:05 chritter

  • Adding the annotation was to disable istio and thus avoid an istio injection that interferes with init containers.
  • The label is no longer needed.
    • Why? currently these modifications to the deployment are manual and thus the istio injection is only necessary manually to run the SeldonDeployment.
  • In the future, perhaps a mutating webhook implementation could insert the annotation sidecar.istio.io/inject: "false" to SeldonDeployment's.

cboin1996 avatar May 12 '22 20:05 cboin1996

@Collinbrown95 this should be added to opt-in feature list

chuckbelisle avatar Nov 02 '22 13:11 chuckbelisle

@chritter Can you please provide me a Seldon example notebook or deployment to test with - I cannot access the links provided above

rohank07 avatar Apr 04 '23 13:04 rohank07