Dustin Deus
Dustin Deus
> How did you ensure that we use the same log level between both components? I mean that we use the same log level to std but we already do...
What's the status here? The PR has been open for too long.
The preview doesn't seem to work.
Fine for me if it is working on prod.
Sorry, I didn't see the tests. Looks pretty solid.
@tdipadova3rd sorry for the delay. I'll review and merge this PR this week :crossed_fingers:
@llc1123 I appreciate the refactoring, but you touched way too many places which aren't related to the issue. This makes reviewing hard.
> The changes are in separate commits and should be easy to be figured out. That's not what I meant.
@llc1123 in order to close the issue. Please create another PR that contains only the fix for https://github.com/StarpTech/apollo-datasource-http/issues/34. The next step is to avoid a performance drop of ~15%. I'll...
Hi @kdybicz sorry for the late response. Your change will give request options precedence over global defaults. This is natural and the current behavior was more of a bug.