gophercap icon indicating copy to clipboard operation
gophercap copied to clipboard

Feature request - filter command to support a list of mac addresses for BPF filtering

Open mpihelgas opened this issue 1 year ago • 2 comments

Currently the YAML file containing BPF filters seems to support only network addresses (i.e., net BPF filter). In some situations it would be nice to be able to also add MAC addresses to be filtered (i.e., ether host BPF filter).

Thanks!

mpihelgas avatar Apr 30 '24 11:04 mpihelgas

Done in https://github.com/StamusNetworks/gophercap/commit/fbe41dfcb5d115c13f7b8efdf2215a8428665465

markuskont avatar Apr 30 '24 11:04 markuskont

Thank you, I'll run some tests to provide more feedback.

First thing I noticed, there seems to be some leftover noisy debug printing on https://github.com/StamusNetworks/gophercap/blob/master/pkg/filter/condition.go#L214

mpihelgas avatar May 08 '24 19:05 mpihelgas