imdb icon indicating copy to clipboard operation
imdb copied to clipboard
verified publisher icon StalkR

NewSeason returns empty episode list and no error

Open StalkR opened this issue 1 year ago • 1 comments

Hey @windblows95,

I just noticed the tests for Season/Episodes from your PR #14 are failing: returning empty season/episode.

The call to NewSeason returns without error but the episode list is empty: https://github.com/StalkR/imdb/blob/master/season_test.go#L174

Test log: https://github.com/StalkR/imdb/actions/runs/12748036337/job/35527355036

  1. If possible, it should catch something went wrong with parsing and return an error (e.g. could not parse).

  2. And then, if you can fix the parsing so it returns the episode list.

Filing this in case you're willing to look into it.

StalkR avatar Jan 13 '25 13:01 StalkR

Addressed in my latest PR

windblows95 avatar Jan 19 '25 22:01 windblows95

fixed in https://github.com/StalkR/imdb/commit/ca5eb25f9202409ff0dafa8216df7b670b06379f

StalkR avatar Mar 23 '25 00:03 StalkR