Stackdriver
Avoid retry on non-recoverable errors.
Rationale behind this change:
in retrieval.manager(), retry with exponential backoff is used when building Stackdriver sample. However, there are 2 types of errors which will always be thrown, and retrying wouldn't help:
- Unknown metric suffix: https://github.com/Stackdriver/stackdriver-prometheus-sidecar/blob/bfe393828ef37496968bada6060b35c5d3dfec25/retrieval/transform.go#L96
- Unknown metric type: https://github.com/Stackdriver/stackdriver-prometheus-sidecar/blob/bfe393828ef37496968bada6060b35c5d3dfec25/retrieval/transform.go#L114
This goal of this change is to avoid retrying on these 2 types of errors. The implementation is to only retry on recoverable errors.
When I implemented this, I also found that seriesCache.refresh() will potentially throw errors which is mostly not recoverable, hence making sure we wouldn't retry on non-recoverable errors.
@jkohen ready for review. please take a look on the new change. The rationale is updated in 1st comment of the PR.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ️ Googlers: Go here for more info.
