st2 icon indicating copy to clipboard operation
st2 copied to clipboard

Bump dnspython to 2.6.1 to fix pack CI failure on py3.10/py3.11

Open nzlosh opened this issue 1 year ago • 3 comments

Update dnspython to v2.6.1 to fix pack CI failing for py3.10 / py3.11 with AttributeError: module 'collections' has no attribute 'MutableMapping'.

nzlosh avatar Oct 19 '24 08:10 nzlosh

dnspython is a transitive dep -- we don't use it directly. It looks like it is a dependency of:

  • eventlet: dnspython>=1.15.0
  • pymongo: dnspython<3.0.0,>=1.16.0

What if we just removed dnspython from our requirements files and let pip pick the version?

Or, what if we just removed the constraint from lockfiles/st2-constraints.txt and update fixed-requirements.txt with whatever version got locked (this is probably similar to what you've done here)?

cognifloyd avatar Oct 19 '24 14:10 cognifloyd

To clarify: the original reason for pinning dnspython in #4997 (an incompatibility between dnspython and pymongo) no longer applies. We've upgraded pymongo several times since then, and it clearly supports newer versions, so the constraint is not needed any more.

cognifloyd avatar Oct 19 '24 14:10 cognifloyd

Dropped pinning for dnspython as suggested.

nzlosh avatar Oct 19 '24 14:10 nzlosh