st2 icon indicating copy to clipboard operation
st2 copied to clipboard

Python 3.8 to 3.11 mongo 7.0

Open guzzijones opened this issue 1 year ago • 5 comments

python 3.12 works. mongodb 7.0 works. I also fixed some unit tests. This merges in @FileMagic and @nzlosh work on mongo 7.0.

guzzijones avatar Sep 09 '24 18:09 guzzijones

@nzlosh @cognifloyd this is now passing testing. pytest doesn't offer a way to split tests so I removed chunk 1 chunk 2, etc.

guzzijones avatar Sep 12 '24 18:09 guzzijones

chunk1 and chunk2 were running the exact same tests from what I can tell. I don't see any usage of NODE_TOTAL or NODE_INDEX in our workflow code or testing code.

guzzijones avatar Sep 12 '24 20:09 guzzijones

chunk1 and chunk2 were running the exact same tests from what I can tell. I don't see any usage of NODE_TOTAL or NODE_INDEX in our workflow code or testing code.

The switch to pytest makes those vars obsolete. They were used by nose-parallel: https://pypi.org/project/nose-parallel/

cognifloyd avatar Sep 13 '24 02:09 cognifloyd

I'm going to slowly review this PR. I plan to look for isolated pieces of this PR that could go in separate PRs to make each bit of functionality easier to review and check for completeness. I understand that breaking up a large PR can be painful, so I'll try to minimize that pain as much as I can.

cognifloyd avatar Sep 13 '24 02:09 cognifloyd

it is mostly just pytest changes.

On Thu, Sep 12, 2024 at 22:38 Jacob Floyd @.***> wrote:

I'm going to slowly review this PR. I plan to look for isolated pieces of this PR that could go in separate PRs to make each bit of functionality easier to review and check for completeness. I understand that breaking up a large PR can be painful, so I'll try to minimize that pain as much as I can.

guzzijones avatar Sep 13 '24 02:09 guzzijones

Merged:

  • cherry-picks the nose -> pytest transition: #6291
  • adding python 3.10 and 3.11 to the GHA test matrix: #6292

The last bits left to cherry-pick from this PR are:

  • pants-related documentation.

cognifloyd avatar Dec 19 '24 18:12 cognifloyd

@guzzijones @cognifloyd Do you agree this PR can be closed now that all commits have been cherry picked and applied to master?

nzlosh avatar Feb 19 '25 09:02 nzlosh

Yeah. I need to revisit adding documentation for using pants, but I can look back at a closed pr just as easily as an open one.

cognifloyd avatar Feb 19 '25 15:02 cognifloyd