st2 icon indicating copy to clipboard operation
st2 copied to clipboard

Add get_result method to st2client

Open skiedude opened this issue 2 years ago • 9 comments

In order to check the results of a given execution, this endpoint is invaluable. The get_output method can sometimes return the information, but not always.

This method will be pulling information from the /api/v1/executions/{id}/result endpoint and returns a json response

skiedude avatar Feb 16 '24 17:02 skiedude

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 26 '24 17:02 CLAassistant

please update the commit or sign the CLA for the Jacob Zufelt commit

guzzijones avatar Mar 07 '24 17:03 guzzijones

@guzzijones sorry about that, fixed

skiedude avatar Mar 07 '24 20:03 skiedude

looks like the lint check failed.

guzzijones avatar Mar 13 '24 21:03 guzzijones

Seems to be unrelated to my change

1. st2-auth-ldap 3.9.dev0 from git+https://github.com/StackStorm/st2-auth-ldap.git@master
    Expected sha256 hash of 29c6ff480b24e4bc316ed69eac5503c71f4700ed17649ae5c5ca8cd745e5852f when downloading st2-auth-ldap but hashed to 1b62240f8004316de753c3e2e20e629d0afb3337ea9a549f9022b4a7ba8c0499.

skiedude avatar Mar 13 '24 22:03 skiedude

Same lint check is failing, not sure how my code change could have done this

1. st2-auth-ldap 3.9.dev0 from git+https://github.com/StackStorm/st2-auth-ldap.git@master
    Expected sha256 hash of 29c6ff480b24e4bc316ed69eac5503c71f4700ed17649ae5c5ca8cd745e5852f when downloading st2-auth-ldap but hashed to 1b62240f8004316de753c3e2e20e629d0afb3337ea9a549f9022b4a7ba8c0499.
    ```

skiedude avatar Mar 14 '24 22:03 skiedude

@guzzijones is there more I need to do, in order to get a 2nd approver?

skiedude avatar Apr 11 '24 21:04 skiedude

@cognifloyd can you do a 2nd review?

skiedude avatar Apr 25 '24 22:04 skiedude

Is the milestone something I need to set? @cognifloyd

skiedude avatar May 08 '24 19:05 skiedude