st2 icon indicating copy to clipboard operation
st2 copied to clipboard

Use pants managed venv in Makefile

Open cognifloyd opened this issue 2 years ago • 1 comments

I don't intend to merge this. I want to use this to find any issues with the requirements pants is using and limit them appropriately. So, the changes to the Makefile are quite hacky.

cognifloyd avatar Feb 10 '24 02:02 cognifloyd

The pants-managed venv does not have PyOpenSSL.

  • Apparently that was pulled in by requests[security] which was disabled in:
    • requests 2.24 (https://github.com/psf/requests/pull/5443):
      • eww. I didn't realize that the urllib3 module was getting monkey patched with pyopenssl.
    • requests 2.25 (https://github.com/psf/requests/pull/5867)

I don't know if that's related to the timeouts in the integration tests or not.

Nope. That's irrelevant because we're already pinned to requests==2.25.1, so we're only getting pyopenssl because of our pin now. If we dropped that it would probably go away. We can also drop the [security] extra since it does nothing.

cognifloyd avatar Feb 16 '24 21:02 cognifloyd