st2 icon indicating copy to clipboard operation
st2 copied to clipboard

remove github repo depencencies

Open guzzijones opened this issue 6 years ago • 1 comments

Please remove the github repo dependencies and change to proper python dependencies. Those of us with dev environments behind firewalls run our own gitlab/github, pypi, and npm repos.

We are working on upstream fixes, but we won't be able to pull request them. We need to change these dependencies to point at our own internal gitlab/git repos.

Unless you have another solution for us to fix dependencies like:

git+https://github.com/StackStorm/orquesta.git@e6ebbbeb2c661486067e659dc7552f0a986603a6#egg=orquesta

guzzijones avatar Jan 27 '20 20:01 guzzijones

Expanding on this, these are the four dependencies and what work needs to be done to fix this:

  • [ ] git+https://github.com/StackStorm/logshipper.git@stackstorm_patched#egg=logshipper
    • Forked from the stackstorm_patched branch of Kami/logshipper
      • Which is forked from ondergetekende/logshipper
        • Which is abandoned (hasn't been updated in five years)
      • With these patches applied (in this order):
        • https://github.com/Kami/logshipper/commit/14c904dc76dbaa03df31d4363dc238e6c2b87389
        • https://github.com/Kami/logshipper/commit/68ede0a42d0329cdf63d7c657f50f55b5e52ead1
        • https://github.com/Kami/logshipper/commit/e98fea55d4d552e87c39702226993a09c7f11cbd
        • https://github.com/Kami/logshipper/commit/a86f613b840471d2b2ca48879dcb6ec91b20c83a
    • [ ] Get all of those commits integrated into a supported, up-to-date, upstream fork
    • [ ] Update requirements.txt to point to whatever PyPI project is created/updated for it
  • [ ] git+https://github.com/StackStorm/orquesta.git@6e2fa8052cd62b07e96e540f68e7290b324d0f01#egg=orquesta
    • Orquesta is already a StackStorm project
    • [ ] Instead of pinning the orquesta dependency to a repo/commit, we should pin it to a PyPI version in requirements.txt
    • @m4dcoder is the go-to person for this
  • [x] git+https://github.com/StackStorm/python-mistralclient.git#egg=python-mistralclient
    • Forked from openstack/python-mistralclient
      • with 110 commits applied to it, so it's a full fork and would be difficult to upstream
    • OpenStack also owns the PyPI project
    • This dependency will be dropped when ST2 drops support for Mistral, which should happen in 1-2 releases.
    • Due to all of that, I don't think it makes sense to turn this into its own PyPI package.
    • [x] Sit tight and wait for 1-2 more ST2 releases. We would gladly accept help with the next few releases as well if you want to speed this up.
    • [x] Remove from requirements.txt
  • [ ] git+https://github.com/StackStorm/st2-auth-backend-flat-file.git@master#egg=st2-auth-backend-flat-file
    • [x] I have registered this on PyPI just now to save the project name.
    • [x] This PR contains fixups to make PyPI project page more up-to-date and useful for users.
    • [x] Review and merge the PR
    • [ ] Update requirements.txt to point to PyPI project

blag avatar Jan 27 '20 22:01 blag

we ran into the same issue, a workaround that doesn't require patching the requirements is:

git config --global url."ssh://[email protected]/.../logshipper.git".insteadOf "https://github.com/StackStorm/logshipper.git"

iodbh avatar Mar 13 '23 15:03 iodbh