orquesta icon indicating copy to clipboard operation
orquesta copied to clipboard

Improve inspect context and detect undefined task logic.

Open yogeshgoyal26 opened this issue 2 years ago • 3 comments

Improvement in inspect context and detect undefined task logic to improve overall execution performance of inspect. Specifically scenarios where the tasks success and failure are moved to same task in the workflow, then in that case the tasks are added to the queue in multiple of 2, which increase the overall time take by inspect method. Below is an example workflow: Task1 - Added 1 time Task2 - Added 2 times Task3 - Added 4 times Task4 - Added 8 times ..

---
version: "1.0"
description: "Test workflow"
input:
- "a1"
- "a2"
tasks:
  Task1:
    action: "core.noop"
    next:
    - when: "<% succeeded()  %>"
      do: "Task2"
    - when: "<% failed() %>"
      do: "Task2"
  Task2:
    action: "core.noop"
    next:
    - when: "<% succeeded()  %>"
      do: "Task3"
    - when: "<% failed() %>"
      do: "Task3"
  Task3:
    action: "core.noop"
    next:
    - when: "<% succeeded()  %>"
      do: "Task4"
    - when: "<% failed() %>"
      do: "Task4"
  Task4:
    action: "core.noop"
    next:
    - when: "<% succeeded()  %>"
      do: "Task5"
    - when: "<% failed() %>"
      do: "Task5"
  Task5:
    action: "core.noop"
    next:
    - when: "<% failed() %>"
      do: "fail"

yogeshgoyal26 avatar Jun 06 '23 10:06 yogeshgoyal26

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: guzzijones
:x: Yogesh Kumar


Yogesh Kumar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 06 '23 10:06 CLAassistant

This looks good to me.

guzzijones avatar Jul 09 '23 15:07 guzzijones

@yogeshgoyal26 Looks like we have a Changelog for Orquestra: https://github.com/StackStorm/orquesta/blob/master/CHANGELOG.rst It would be helpful to include a description for this enhancement in there too for completeness.

arm4b avatar Jul 11 '23 17:07 arm4b