StackStorm
(WIP) Remove undocumented ST2_AUTH_TOKEN from st2chatops
ST2_AUTH_TOKEN is not documented in st2chatops.env and because the token either has a long expiry time or the expiry time is so short the ChatOps service is restarted all the time to pick up the config changes. It is no point to keep it, therefore remove this auth method from hubot-stackstorm entirely.
I don't see any significant benefit in removing token comparing to other tasks, but not opposted with the change itself.
To make it happen, please check other StackStorm repos if we use any ST2_AUTH_TOKEN with chatops, for example in tests, CI, Docker images or other possible places.
Additionally, don't forget about changelog record and package version change.
To make it happen, please check other StackStorm repos if we use any ST2_AUTH_TOKEN with chatops, for example in tests, CI, Docker images or other possible places.
Thanks for point it out and you had good point. Already found some test codes depend on ST2_AUTH_TOKEN. I am studying coffeescript and read https://github.com/StackStorm/hubot-stackstorm/pull/133 how hubot-stackstorm is refracted. It came ST2_AUTH_TOKEN discussion and don't want too many changes in one activity. I will leave this PR alone for now.
I found this PR pretty minimal and easy to change, I'm probably missing some background discussion around https://github.com/StackStorm/hubot-stackstorm/pull/133.
As for other dependent repos that rely on token in chatops, - it would be nice to see those PRs first. It looks like we have a freedom of removing all the uses of ST2_AUTH_TOKEN as a step before merging this particular change.
I found this PR pretty minimal and easy to change, I'm probably missing some background discussion around #133.
As for other dependent repos that rely on token in chatops, - it would be nice to see those PRs first. It looks like we have a freedom of removing all the uses of ST2_AUTH_TOKEN as a step before merging this particular change. T
Good point again, thanks!
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
