tirith icon indicating copy to clipboard operation
tirith copied to clipboard

fix:Upgrade Python version from 3.8 to 3.11

Open Denish3436 opened this issue 1 year ago • 3 comments

This PR solve issue #183

  • [ x] I havd Changed the python_version field from 3.8 to 3.11 in the Pipfile.
  • [ x] Verify that all dependencies are compatible with Python 3.11.

Denish3436 avatar Oct 06 '24 10:10 Denish3436

hii @refeed The issue seems to be stemming from a missing exceptiongroup module. so i am working on it

Denish3436 avatar Oct 09 '24 03:10 Denish3436

Hi @Denish3436 , the test is still failing, we need to take a look again. I'm not really sure what's the root problem of this. The issue seems more complicated than I thought earlier :)

    res = hook_impl.function(*args)
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/_pytest/config/__init__.py", line 1140, in pytest_cmdline_parse
    self.parse(args)
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/_pytest/config/__init__.py", line 1494, in parse
    self._preparse(args, addopts=addopts)
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/_pytest/config/__init__.py", line 1366, in _preparse
    self._initini(args)
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/_pytest/config/__init__.py", line 1239, in _initini
    rootpath, inipath, inicfg = determine_setup(
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/_pytest/config/findpaths.py", line 198, in determine_setup
    rootdir, inipath, inicfg = locate_config(invocation_dir, [ancestor])
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/_pytest/config/findpaths.py", line 110, in locate_config
    ini_config = load_config_dict_from_file(p)
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/_pytest/config/findpaths.py", line 64, in load_config_dict_from_file
    import tomli as tomllib
ModuleNotFoundError: No module named 'tomli'

Ideally, when we update the Python version, we shouldn't add more dependencies, it should work out of the box. The worst case might be we need to upgrade the versions of our direct dependencies that are defined within the Pipfile not the dependencies of our dependencies

refeed avatar Oct 15 '24 12:10 refeed