dnscontrol icon indicating copy to clipboard operation
dnscontrol copied to clipboard

GCORE: support metadatas for controlling GeoDNS/Failover

Open xddxdd opened this issue 1 year ago • 1 comments

Add metadata fields for configuring Gcore's GeoDNS and Healthcheck/Failover functionalities, as well as documentations for them.

Tested manually with my own config.

As a side note, I didn't add any automated tests because I'm not sure how we should do so for custom metadata fields. Should I add them as testgroups in integrationTest/integration_test.go?

xddxdd avatar Oct 20 '24 20:10 xddxdd

Neat stuff! Thanks for the PR!

Yes, please add integration tests. Just limit them to GCORE similar to how Clouldflare's proxy tests are just for CLOUDFLAREAPI.

See this example around line 1964:

testgroup("CF_PROXY A create",
      only("CLOUDFLAREAPI"),

tlimoncelli avatar Oct 21 '24 13:10 tlimoncelli

Added integration test, and made some small changes to the code to make it play nice with integ test.

xddxdd avatar Oct 24 '24 03:10 xddxdd

Great new feature! I love the withMeta() function that makes testing so easy.

I've rebased. Anything else before merging?

tlimoncelli avatar Oct 28 '24 17:10 tlimoncelli

Looks good to me.

xddxdd avatar Oct 29 '24 04:10 xddxdd