Stacks-Editor icon indicating copy to clipboard operation
Stacks-Editor copied to clipboard

feat: support copy/pasting tag link nodes in rich text mode

Open aalear opened this issue 3 years ago • 2 comments

This PR addresses tag link serialization for #56.

The core of the change is switching from NodeView to a schema definition with appropriate toDOM/parseDOM implementations.

It looks like we never wrote tests for the original NodeView nor do we have existing tests for other schema specifications. I'm happy to take a stab at adding some, but for now I left them out.

Also note that pasting from a final rendered document is not currently supported. Part of the issue is that public Q&A still uses .post-tag rather than .s-tag from Stacks. I'm not sure if it's worth adding .post-tag checks into the editor repo. Feels like we should be moving towards making the Q&A rendering use Stacks classes instead, although that's also a non-trivial undertaking.

aalear avatar Jul 13 '22 21:07 aalear

Deploy Preview for stacks-editor ready!

Name Link
Latest commit 0601f85945bf214e74f883bab107cdd070812e42
Latest deploy log https://app.netlify.com/sites/stacks-editor/deploys/630e4972483aa70008aafe4e
Deploy Preview https://deploy-preview-177--stacks-editor.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jul 13 '22 21:07 netlify[bot]

@b-kelly I re-tested this the other day and I think everything is good to go. No feature-related changes needed after #158 went in.

aalear avatar Aug 16 '22 15:08 aalear