Stacks-Editor icon indicating copy to clipboard operation
Stacks-Editor copied to clipboard

fix: Defaulting emphasis input/serialization to _ from *

Open tmcentee opened this issue 3 years ago • 2 comments

Closes #59 .

Describe your changes

This simply changes the default Markdown serialization for emphasis (italics) from * to _. This now allows text with overlapping marks (e.g. bold and italics) to roundtrip between rich text and markdown successfully.

emphasis

In rich-text mode, either _ or * can be used to mark text with emphasis. Both will serialize to _ in Markdown. auto-format

PR Checklist

  • [ ] All new/changed functionality includes unit and (optionally) e2e tests as appropriate
  • [ ] All new/changed functions have /** ... */ docs
  • [ ] I've added the bug/enhancement and other labels as appropriate

Environment(s) tested

  • Device: Desktop
  • OS: Win10
  • Browser: Chrome
  • Version: 103

tmcentee avatar Jul 12 '22 15:07 tmcentee

Deploy Preview for nifty-lalande-39c157 ready!

Name Link
Latest commit 82589fa5508d3555206d599f98f3e13c82c10b31
Latest deploy log https://app.netlify.com/sites/nifty-lalande-39c157/deploys/62cd902807b51b000908eb0f
Deploy Preview https://deploy-preview-161--nifty-lalande-39c157.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jul 12 '22 15:07 netlify[bot]

cc @b-kelly I know you had commented on the reporting Meta post about some edge cases you can think of. Let me know if you still have any in mind that I'll need to check out here.

https://meta.stackexchange.com/questions/360033/opt-in-alpha-test-for-a-new-stacks-editor/360136#comment1202381_360136

tmcentee avatar Jul 12 '22 18:07 tmcentee

@b-kelly This has been orphaned for a while. Still on the radar to eventually ship or should I close?

tmcentee avatar Feb 21 '23 15:02 tmcentee