Squally icon indicating copy to clipboard operation
Squally copied to clipboard

No Emerge/Submerge SFX if Squally is up against a wall.

Open zcanann opened this issue 6 years ago • 0 comments

See EntityMovementCollisionBehavior.cpp, specifically here:

	this->movementCollision->whenCollidesWith({ (int)PlatformerCollisionType::Water, }, [=](CollisionObject::CollisionData collisionData)
	{
		if (this->groundCollision != nullptr && !this->groundCollision->isOnGround() && this->noEmergeSubmergeSoundCooldown <= 0.0f && !this->submergeSound->isPlaying())
		{
			this->submergeSound->play();
		}

		return CollisionObject::CollisionResult::DoNothing;
	});

I believe isOnGround() is returning true when it shouldn't. Being up against a wall shouldnt hit the ground detector, so I'm not sure what is going wrong.

zcanann avatar Apr 17 '20 19:04 zcanann