Action-SpigotMC icon indicating copy to clipboard operation
Action-SpigotMC copied to clipboard

build(deps): bump ssh2-sftp-client from 11.0.0 to 12.0.0

Open dependabot[bot] opened this issue 1 year ago • 1 comments

Bumps ssh2-sftp-client from 11.0.0 to 12.0.0.

Release notes

Sourced from ssh2-sftp-client's releases.

Major Version Change - Remove retry support

The main change in this version is the removal of the connectiuon retry support. There are 2 main reasons this support has been removed -

  • It provided little benefit over the added connection logic complexity. In 90% of cases, a connection which fails on the first attempt fails all subsequent retries. Very rarely does a connection which fails on the first attempt succeed with one of the retry attempts. This approach did have some benefit in the past when networks were slower and often more congested, but advances in technology, network speeds and infrastructure quality mean the sorts of problems we use to encounter and less prevelent.
  • The inclusion of retry support significantly complicates the event handling logic and creates some rare, but not unknown, corner cases where events don't get correctly handled and can result in the connection promise handing indefinitely, being neither resolved or rejected. The retry support also had a performance hit which could actually cause connection problems, especially on a slower network using a slower key excahgne or cipher.

The other reason to remove this support is that should someone want to have such support, it can easily be added in their own use case via one of the retry promise packages available and can be tailored to their specific needs. Maintaining a flexible and general implementation which did not have any negative impact is much harder and adds an additional maintenance burdon which is only beneficial for a small number of use cases.

The other change in this version is that we are no longer testing against v18.x of node. Highly recommended that at least version v20.x is used.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot[bot] avatar Apr 01 '25 18:04 dependabot[bot]

@dependabot recreate

SpraxDev avatar Jun 12 '25 11:06 SpraxDev

Looks like ssh2-sftp-client is up-to-date now, so this is no longer needed.

dependabot[bot] avatar Jun 12 '25 11:06 dependabot[bot]