SpongeForge icon indicating copy to clipboard operation
SpongeForge copied to clipboard

@IsCancelled(Tristate.UNDEFINED) not working with mods canceling EntityTravelToDimensionEvent

Open Sir-Will opened this issue 5 years ago • 0 comments

I am currently running

  • SpongeForge version: spongeforge-1.12.2-2838-7.2.4-RC4073
  • Forge version: forge-1.12.2-14.23.5.2847-universal
  • Plugins/Mods: GameStages-1.12.2-2.0.117 DimensionStages-1.12.2-2.0.23 CraftTweaker2-1.12-4.1.19

Issue Description When listening to the MoveEntityEvent.Teleport event with the @IsCancelled(Tristate.UNDEFINED) annotation to get notified even if the event is cancelled and a mod is cancelling the forge EntityTravelToDimensionEvent event, MoveEntityEvent.Teleport is not being notified.

Sponge:

@Listener
@IsCancelled(Tristate.UNDEFINED)
public void onPlayerTeleport(MoveEntityEvent.Teleport event, @Getter("getTargetEntity") Player player) {
    System.out.println("Teleport");
}

Forge: https://github.com/Darkhax-Minecraft/DimensionStages/blob/master/src/main/java/net/darkhax/dimstages/DimensionStages.java#L34

Sir-Will avatar Aug 29 '20 20:08 Sir-Will