MixinGradle icon indicating copy to clipboard operation
MixinGradle copied to clipboard

Shadows aren't reobfuscated on next gradle build after not changing any source files

Open Niko-sk2x opened this issue 7 years ago • 6 comments

I'm not sure which exact task being skipped causes it, but it's definitely not nice. I have to run clean build every time I want to build the mod and to someone who doesn't know that, it's not at all obvious. And the error in obfuscated environment is even more unobvious than in the previous issue with refmap.

Niko-sk2x avatar Oct 02 '18 08:10 Niko-sk2x

Which gradle version (since I think something with a task being skipped might depend on it since the new ones have been focusing on incremental compilation)?

Pokechu22 avatar Oct 02 '18 14:10 Pokechu22

I do use a pretty recent gradle version, currently not yet updated from some early nightly build of 4.10. I use that version because this was one of the first versions that supported snapshot plugin versions to be used with new plugins { } syntax, which allows kotlin-dsl to automatically generate all the accessors. I can't easily re-test on older gradle version, but I remember this issue being there for a long time, long before even 4.8.

Niko-sk2x avatar Oct 02 '18 14:10 Niko-sk2x

I'm fairly sure that there have been some Gradle backwards compatibility issues for MixinGradle, leading to Sponge even using Gradle 3.3 for it's wrapper. I can't say for sure that's the leading cause, but you could give that a shot with old groovy plugins, otherwise, it's a matter of waiting for MixinGradle updating for newer versions of Gradle.

gabizou avatar Oct 02 '18 15:10 gabizou

Unfortunately I would have to rewrite pretty much the whole buildscript to go back to gradle 3.x. Going forwards is much easier as the buildscript can be modified incrementally to use new features, and old ones still work.

Niko-sk2x avatar Oct 02 '18 15:10 Niko-sk2x

This issue still affects 0.7-SNAPSHOT.

Pokechu22 avatar May 17 '20 19:05 Pokechu22

Will this issue ever be fixed? It's just started happening to me, meaning it's hard to share my mod as only about 20% of people can launch with it.

surge541 avatar Aug 26 '22 22:08 surge541