splide icon indicating copy to clipboard operation
splide copied to clipboard

Tap targets are not sized appropriately

Open bes-internal opened this issue 3 years ago • 3 comments

Checks

  • [X] Not a duplicate.
  • [X] Not a question, feature request, or anything other than a bug report directly related to Splide. Use Discussions for these topics: https://github.com/Splidejs/splide/discussions

Version

v4.1.3

Description

Interactive elements like buttons and links should be large enough (48x48px), and have enough space around them, to be easy enough to tap without overlapping onto other elements.

image

Reproduction Link

No response

Steps to Reproduce

.

Expected Behaviour

Need to change the size of the arrows or make a transparent area around the arrows for the minimum size

bes-internal avatar Jan 10 '23 09:01 bes-internal

Pagination is failing the tap-targets lighthouse audit for me as they are too close together and not large enough of a hitbox for the button. I think this is at least partly your problem.

image

If you customize the buttons to be a minimum of 48x48px then it passes the audits but it would be nice if it passed without having to modify these. Or you could disable pagination.

Unfortunately trying to satisfy this requirement means making the pagination buttons large, intrusive and not very appealing IMO.

dplarina avatar Feb 27 '23 20:02 dplarina

I think it would be a good decision to remove buttons from pagination by default (leave this just as a visual reference) and increase the scroll buttons paddings (this is easy to do and a really useful)

bes-internal avatar Feb 27 '23 21:02 bes-internal

It should suffice to change to buttons to a span. Or are the buttons as an element doing anything?

mm-mereien avatar Jun 27 '23 13:06 mm-mereien