spikeinterface icon indicating copy to clipboard operation
spikeinterface copied to clipboard

Circus2 pipeline

Open yger opened this issue 3 years ago • 3 comments

Fixing some small bugs in the OMP peeler, and enhancing spykingcircus2. Figures for Sam will follow soon :-)

yger avatar Sep 28 '22 11:09 yger

@merging that ? Bugs should be fixed, peeler is fine, I guess this will be rather stable from now on. I'll benchmarks that for next meeting, presenting results

yger avatar Oct 07 '22 14:10 yger

@yger happy with this?

alejoe91 avatar Oct 13 '22 10:10 alejoe91

Yes and no. Yes, because results are good, but no because ideally, I should make my peeler robust to chunk sizes (results are the same, but the speed is not). Maybe we can leave it aside for now, don't know. This is just optimization, but the circus-omp peeler will not work if chunk of more than hundreds of ms are given, currently

yger avatar Oct 14 '22 08:10 yger

@yger 2 things:

  1. can you add SpykingCircus2 in the docs (installed sorters)?
  2. When n_jobs=-1, can you set n_jobs=os.cpu_count()? Otherwise it fails on Windows

alejoe91 avatar Oct 19 '22 07:10 alejoe91

@yger just pushed some small changes to the docs.

Ready to merge on my side. @samuelgarcia ?

alejoe91 avatar Oct 20 '22 16:10 alejoe91