Circus2 pipeline
Fixing some small bugs in the OMP peeler, and enhancing spykingcircus2. Figures for Sam will follow soon :-)
@merging that ? Bugs should be fixed, peeler is fine, I guess this will be rather stable from now on. I'll benchmarks that for next meeting, presenting results
@yger happy with this?
Yes and no. Yes, because results are good, but no because ideally, I should make my peeler robust to chunk sizes (results are the same, but the speed is not). Maybe we can leave it aside for now, don't know. This is just optimization, but the circus-omp peeler will not work if chunk of more than hundreds of ms are given, currently
@yger 2 things:
- can you add SpykingCircus2 in the docs (installed sorters)?
- When
n_jobs=-1, can you setn_jobs=os.cpu_count()? Otherwise it fails on Windows
@yger just pushed some small changes to the docs.
Ready to merge on my side. @samuelgarcia ?