Source-X icon indicating copy to clipboard operation
Source-X copied to clipboard

Verifying account with wrong password/ban/no account

Open criminalx opened this issue 5 years ago • 5 comments

When I try to login with a wrong password, no account, banned account, wrong encryption, it always says: verifying account

https://puu.sh/FILLC/72698dffaa.png

Tested with client 203 and 509

criminalx avatar May 10 '20 20:05 criminalx

i can confirm. see from lot time ago.

GitMadKing avatar May 11 '20 07:05 GitMadKing

I make some test:

  • ClassicUO client not get any problem
  • Client 7.0.10.0 also not any problem

Possible happen only on very old client

This is my ini settings:

ClientVersion=7.0.20.0

// Set this to 1 to allow login to encrypted clients
UseCrypt=1

// Set this to 1 to allow login to unencrypted clients
UseNoCrypt=1

alexdan2 avatar May 12 '20 09:05 alexdan2

Its only working for clients up to 7.

i maked test comment that line:

//if ( GetNetState()->m_clientVersion || GetNetState()->m_reportedVersion ) // only reply the packet to valid clients

and now giving error on 203 of bad password.

alexrmrm avatar May 20 '20 07:05 alexrmrm

After a bit checking, the reason of the issue is really simple, it's because 0xEF packet only sent by 6x+ fully, so older clients doesn't send client data in pre login. So m_reportedVersion never set for older versions. (Older clients still send this packet but only send seed not client datas.)

I agree the alex solution, because I don't think we need to avoid sending reply that packet comes from client's itself. If some clients (which is made by coders not uo's itself) has issue with this packet, they should care of it. Honestly I don't understand why the developer restricted the reply with 6x+ clients or KR version clients.

As we see information in here; https://docs.polserver.com/packets/index.php?Packet=0xEF Client datas only sent by KR and Latest 6x+ clients, so using that packet to restricting reply causes this issue, cancelling this line which alexrmrm quoted may be the best solution.

xwerswoodx avatar Dec 22 '20 03:12 xwerswoodx