FlightControl icon indicating copy to clipboard operation
FlightControl copied to clipboard

Disable Timer on World Change

Open nivcoo opened this issue 4 years ago • 10 comments

Hi of course you can test, the concern was that the time continued when we were in a world without fly and being on the ground. It is therefore necessary when people can not fly deactivate the fly and pause the timer.

nivcoo avatar Mar 15 '21 16:03 nivcoo

This commit didn't change anything and added a few lines of code, so I just reverted it.

Spazzinq avatar Mar 15 '21 18:03 Spazzinq

He add world change event....

nivcoo avatar Mar 15 '21 18:03 nivcoo

It's my mainly change in this pull request

nivcoo avatar Mar 15 '21 18:03 nivcoo

Player world in the teleport event is the previous world so we have an issue with that

nivcoo avatar Mar 15 '21 18:03 nivcoo

And i've add check to detect if the teleport event is a world change or not to remove the useless check

nivcoo avatar Mar 15 '21 18:03 nivcoo

He add world change event.... And i've add check to detect if the teleport event is a world change or not to remove the useless check

The teleport event includes if it's a world change. How does it add any functionality/fix anything?

Spazzinq avatar Mar 15 '21 18:03 Spazzinq

Add debug on p.getWorld() on teleport event and you can look the issue :p

nivcoo avatar Mar 15 '21 18:03 nivcoo

it sends the check to the old world and therefore activates the fly in a world where the fly is deactivated

nivcoo avatar Mar 15 '21 18:03 nivcoo

Okay thx i will edit the file to add a function to do that more properly

nivcoo avatar Mar 15 '21 19:03 nivcoo

Hello, some news ? thx

nivcoo avatar May 15 '22 19:05 nivcoo