Small packages fixes
There was an unused package (postcss-shorthand-expand) and a used package that was installed by a dependency (postcss-selector-parser) that should have been installed.
I also installed babel-runtime to all the packages since they could be installed independently of the main heml package.
Just wondering if this is going to land soon? I believe the missing dependency is preventing me from installing heml with pnpm.
(it does technically install, but running heml -h yields an error)
Hey Michael, sorry about that! Can you share the error you're getting? I'll resolve the conflicts on this and get it merged today!
No worries! I’ve temporarily worked around the issue, so it’s no biggie.
$ heml -h
module.js:472
throw err;
^
Error: Cannot find module 'postcss-selector-parser'
at Function.Module._resolveFilename (module.js:470:15)
at Function.Module._load (module.js:418:25)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Object.<anonymous> (/path/to/node_modules/.registry.npmjs.org/@heml/styles/1.1.2/node_modules/@heml/styles/build/plugins/postcss-element-expander/tagAliasSelectors.js:35:30)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:488:32)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
I should also add that I love this project, so thanks for your work! :)
I'm glad it helps!
Any chance you can test this branch out before I merge it? You can follow the instructions here. Just be sure to check out the small-packages-fixes branch.
Okay, so I followed those instructions, and it worked on both the master and small-packages-fixes branches, so I changed all the npm references to pnpm (including inside all the npm scripts) and then I hit a couple of errors:
-
babel-coreis peer dependency ofgulp-babeland is missing from the devDependencies of./package.json -
fs-extrais a missing from the dependencies of./packages/heml-elements/package.json
After I installed those missing dependencies I could successfully run ./packages/heml/build/bin/heml.js -h
Any news about this PR being merge? @avigoldman
We cannot use heml with pnpm because of this.