Rock icon indicating copy to clipboard operation
Rock copied to clipboard

GitHub Workflows security hardening

Open sashashura opened this issue 3 years ago • 1 comments

This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted. It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

sashashura avatar Aug 29 '22 08:08 sashashura

Please let me know if you have any questions.

sashashura avatar Sep 20 '22 06:09 sashashura

@Kwame-Agyei?

sashashura avatar Nov 30 '22 22:11 sashashura

Thank you. We're removing the develop_ttrockwebapp.yml file (https://github.com/SparkDevNetwork/Rock/commit/c91ec89e250a193b303cd5d9e8e2981f549ef875) from the project as it was auto-added at some point in the past and it's no longer used/needed.

nairdo avatar Dec 09 '22 22:12 nairdo