Defined Value attribute field type does not omit inactive defined values from "Selectable Values" list when "Include Inactive" is not checked

[briankalwat]

Prerequisites

• [X] Put an X between the brackets on this line if you have done all of the following:
  • Did you perform a search at https://github.com/issues?q=is%3Aissue+user%3ASparkDevNetwork+-repo%3ARock to see if your bug or enhancement is already reported?
  • Can you reproduce the problem on a fresh install or the demo site?
  • Did you include your Rock version number and client culture setting?

A Picture Is worth a Thousand Words

Description

We have a defined value workflow attribute that is referring to a defined type we have set up for our ministries. One of the defined values in that defined type – Rally – we have set to be inactive. Even though we have "Include Inactive" unchecked, it is still showing Rally in the "Selectable Options" list.

I'm not sure if checking a box for an inactive defined value in the "Selectable Options" list actually makes it selectable, but in our mind, if "Include Inactive" is not checked, it should not be including inactive defined values, even in the selectable options list.

Steps to Reproduce

1. Create a Defined Type
2. Create a Defined Value and set it to inactive
3. Create a Workflow
4. Create a Workflow Attribute with a field type of "Defined Value"
5. See inactive defined value in the list of selectable options

Expected behavior:

Inactive defined values should not be visible in the list of selectable options on defined value field types, unless the checkbox for "Include Inactive" is checked.

Actual behavior:

Inactive defined values are included in the list of selectable options for defined value field types, even though the "Include Inactive" checkbox is not checked.

Versions

• Rock Version: 14.0.11
• Client Culture Setting: en-US