Rock icon indicating copy to clipboard operation
Rock copied to clipboard

Schedule Financial Transactions Defaulting to "Contribution" Instead of Transaction Type Determined by Transaction Entry Block Settings

Open KCKurz opened this issue 3 years ago • 0 comments

Description

The Transaction Entry Block has a block setting to change Transaction Type of the transaction. When completing a transaction with the frequency of one-time, the transaction will include the Transaction Type chosen in the block setting. However, when changing the frequency to make the transaction a scheduled transaction, the transaction type is not being set on the transaction, which results in the transaction having a default value of "Contribution" even if the Transaction Type is set to "Event Registration".

This causes confusion because one-time transactions can have the correct Transaction Type, where scheduled transactions will have a different Transaction Type.

Steps to Reproduce

  1. Edit Block Configuration for Transaction Entry Block
  2. Go to Advanced Settings
  3. Change Transaction Type to "Event Registration"

Give-Now-External-Website )

  1. Click Save
  2. Change Frequency to "Weekly"

Give-Now-External-Website (1)

  1. Complete a Transaction
  2. View the Scheduled Transaction

Scheduled-Transaction-Rock-RMS

Expected behavior:

I would expect the TransactionTypeValueId property to be set on the FinancialScheduledTransaction.

Actual behavior:

The TransactionTypeValueId property is not set on the FinancialScheduledTransaction. We ran a quick SQL Query to determine if the value was being set:

SELECT
    [AuthorizedPersonAliasId]
    , [TransactionTypeValueId]
    , [FinancialGatewayId]
    , [GatewayScheduleId]
    , [TransactionCode]
    , [SourceTypeValueId]
    , [TransactionFrequencyValueId]
    , [StartDate]
    , [IsActive]
FROM
    [FinancialScheduledTransaction]
WHERE
    [Id] = 1

missing-transaction-type-value-id

We believe this property will be auto-filled with the "Contribution" Transaction Type value if the property is null, instead of being populated with the correct Transaction Type determined by the block settings.

Versions

  • Rock Version: Rock McKinley 14.0 (1.14.0.9)
  • Client Culture Setting: en-US

KCKurz avatar Apr 22 '22 18:04 KCKurz