imgui-java icon indicating copy to clipboard operation
imgui-java copied to clipboard

Update imnodes bindings to latest version & fix getNode___SpacePos bindings

Open serivesmejia opened this issue 1 year ago • 5 comments

Pulls latest commit of imnodes which includes new function SnapNodeToGrid, generates ast & api, fixes getNode___SpacePos functions to actually return ImVec2

(sigh... finally got this right using WSL)

Type of change

  • [ ] Minor changes or tweaks (quality of life stuff)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

serivesmejia avatar Sep 30 '24 16:09 serivesmejia

Also addresses #193 from a while back...

serivesmejia avatar Oct 06 '24 19:10 serivesmejia

Looks much better. But can you also address those changes?

image

Methods now accept ImNodesStyle class. You just need to add an optional argument to them. You can do it in the same way it's done here:

https://github.com/SpaiR/imgui-java/blob/c776b1b384332fee7f016c33aa6e06d0d7f120f3/imgui-binding/src/main/java/imgui/ImGui.java#L288-L304

SpaiR avatar Oct 08 '24 06:10 SpaiR

Hopefully that should do it

serivesmejia avatar Oct 08 '24 10:10 serivesmejia

is there an eta on when this might be released?

serivesmejia avatar Oct 14 '24 18:10 serivesmejia

is there an eta on when this might be released?

Not anytime soon.

SpaiR avatar Oct 15 '24 05:10 SpaiR

Thank you so much😅 it is such a relief to finally get rid of all those // TODO, and also being able to see stacktraces for imnodes assertion errors... This will make my life so much easier.

serivesmejia avatar Oct 31 '24 11:10 serivesmejia