Tero Marttila
Tero Marttila
This will conflict with #3178
This should AFAIK be up to date and ready for review.
Needs rewrite (?) to match up with #2689
Keeping this on the 1.4.0 milestone, because the way the `ContainerHealthCheckWorker` restarts interact with the `ServicePodWorker` has changed, so it should be fixed.
This is a change that needs to happen in some form, but not for 1.4.x anymore, I think. I also have an WIP branch that does something similar to integrate...
Should this be milestoned for 1.5?
I suggest something like this: ``` [done] Triggering deployment of stack test [done] Waiting for deployment to start [done] Deploying service (1/3) foo: ⊛ * Deploying service (2/3) bar: ⊛⊛⊙⊙⊝⊝⊝...
The server `/v1/stacks/:grid/:stack/deploys/:deploy` API is missing the `services_count` information needed to display the `Deploying service (X/Y) ...` thing, but that's trivial to add: ```patch diff --git a/server/app/views/v1/stack_deploys/_stack_deploy.json.jbuilder b/server/app/views/v1/stack_deploys/_stack_deploy.json.jbuilder index bbad1c3..f07d449...
#2221 also introduces a new `ServiceDeploy.queued_at` timestamp as part of the deploy API... a service that is `queued_at` but not yet `started_at` means that it is queued for deployment, presumably...
@kke reckon we could still get this done for 1.4?