standards icon indicating copy to clipboard operation
standards copied to clipboard

[BUG] Conformance check for scs-0211-v1 (and v2) is broken

Open martinmo opened this issue 1 year ago • 10 comments

  • the standard v1 doesn't require a default storage class
  • but the script will fail if it doesn't exist (so it already does what we intend to do in v2 #658)

martinmo avatar Jul 18 '24 14:07 martinmo

I reviewed and tested the script, unfortunately it appears to be broken in more ways, therefore I broadened the scope of this issue:

  • it uses packages not specified in requirements.txt
  • it doesn't yet check what CSI provider is used, to make an informed decision if the storage is local/ephemeral or not (e.g., using a simple local-path provisionar like kind sets up already satisfies the script)
  • it requires some sonobuoy result file which isn't mentioned anywhere else

martinmo avatar Jul 19 '24 14:07 martinmo

after recompiling requirements and deleting gen_sonobuoy function and function calls i could successfully test my kind cluster with the default "storageClassName":"standard" . I will now try to provoke errors to see, if it still needs debugging

fraugabel avatar Sep 03 '24 10:09 fraugabel

There are problems as soon as errors occur. In the event of an error, the test-pvc is not removed, which leads to errors when the test is repeated. So i will have a look into the clean-up-part

fraugabel avatar Sep 09 '24 09:09 fraugabel

I am back on this issue and wonder, whether i should dig deeper into that problem, meaning (write a cleanup bypass part for cleaning up, when errors occur) or port it to sonobuoy right a way?

fraugabel avatar Oct 02 '24 07:10 fraugabel

I'm afraid I can't tell what's happening here. Does this have a (non-) associated PR that I could look at?

mbuechse avatar Oct 07 '24 20:10 mbuechse

@mbuechse right now there is no PR but a branch you can look at. What i am currently working on (from tomorrow on) is the error handling (the exceptions need to be in the right block to get a usable log) https://github.com/SovereignCloudStack/standards/tree/issue/662_default_storage_class

fraugabel avatar Oct 22 '24 14:10 fraugabel

It would be great to have a PR. You can open it as draft.

mbuechse avatar Oct 22 '24 14:10 mbuechse

What is happening here? Of course, there is a PR, and has been since Sep 9?! https://github.com/SovereignCloudStack/standards/pull/745

mbuechse avatar Oct 25 '24 11:10 mbuechse

What is happening here? Of course, there is a PR, and has been since Sep 9?! #745

@fraugabel Please update this issue or close it, if all tasks are done!

anjastrunk avatar Nov 25 '24 07:11 anjastrunk

the progress can be seen here: https://github.com/SovereignCloudStack/standards/tree/issue/662_default_storage_class

currently waiting on feedback or merge

fraugabel avatar Nov 25 '24 08:11 fraugabel

closing in favor of #930

mbuechse avatar May 22 '25 14:05 mbuechse