standards icon indicating copy to clipboard operation
standards copied to clipboard

#675 - Node to Node encryption

Open fdobrovolny opened this issue 1 year ago • 2 comments

Relates: https://github.com/SovereignCloudStack/issues/issues/675

fdobrovolny avatar Jul 08 '24 08:07 fdobrovolny

@OgarOgarovic check the failed pipelines

matofeder avatar Sep 25 '24 13:09 matofeder

generally LGTM, but I want to reread it a second time, as it's quite a long document, at the very least there are some spelling mistakes lurking in there imho, but I didn't want to comment on minor errors before actually having read the whole thing first.

Will provide more feedback, hopefully tomorrow. Thanks for working on this!

@artificial-intelligence would you like to provide more feedback on this?

matofeder avatar Oct 01 '24 08:10 matofeder

@mbuechse @artificial-intelligence can we merge this one or do you have some further comments/discussion points?

matofeder avatar Oct 10 '24 12:10 matofeder

What is the reason for putting it into the Drafts folder? Why was it merged in "Proposal" state? If it's a decision record that has been accepted by the corresponding team (I guess Team IaaS in this case), then the status field should be Draft, the file should be renamed to, say, scs-0122-v1-node-to-node-encryption.md and be put under Standards.

mbuechse avatar Nov 05 '24 09:11 mbuechse

What is the reason for putting it into the Drafts folder? Why was it merged in "Proposal" state? If it's a decision record that has been accepted by the corresponding team (I guess Team IaaS in this case), then the status field should be Draft, the file should be renamed to, say, scs-0122-v1-node-to-node-encryption.md and be put under Standards.

@mbuechse It makes sense. We will rename it and put it under the Standards. Before that, we will ask team IaaS for final validation. Thanks for bringing this up!

matofeder avatar Nov 05 '24 09:11 matofeder

PR here

OgarOgarovic avatar Nov 05 '24 12:11 OgarOgarovic